On Fri, 2019-12-06 at 03:23 -0500, Tim Harder wrote:
> On 2019-12-05 Thu 17:00, Alexis Ballier wrote:
> > > > pkgcheck is mostly used by your CI checks for
> > > > producing huge reports, which is nice but addresses a different
> > > > problem
> > > There is nothing stopping you from running pkgcheck locally.  In
> > > fact,
> > > it should work out of the box these days.  If you have any problems,
> > > please report them and I'm sure they will be addressed promptly.
> > Sure I did that to get reports like what CI does for me now but that's
> > always been a different usecase; I wasn't aware pkgcheck had the
> > equivalent of repoman commit
> 
> While I dislike contributing more to this off-topic tangent, since I've
> fielded this question/request in IRC a few times in the past I figure I
> might as well address it again here for the IRC-averse.
> 
> Personally I use pkgcheck as a QA tool and *git* (or another vcs tool)
> as a commit tool, just like how I used to use repoman and cvs a long
> time ago. I generally dislike when cli tools amalgamate disparate
> features that they weren't designed for so no one has been able to
> convince me why a tool designed to verify ebuilds and their related
> repos should support commit capabilities internally.
> 
> Furthermore, pkgcheck was designed to scale towards scanning multiple
> pkgs, custom restrictions, or entire repos while I assume the majority
> of repoman usage is run against singular pkgs. In many cases, a
> multi-pkg scan doesn't map to a single commit so that functionality
> would be pretty useless in those situations.
> 

Exactly.  Building a workflow on 'repoman commit' is a horrible waste of
time.  This in turn causes developers to make worse commits (e.g. by
combining a lot of irrelevant changes just to workaround the workflow). 
It might have been necessary in times of CVS when we had to jump through
hoops to commit.  It doesn't fit git world anymore.

A much better workflow is to commit first, then run pkgcheck
on everything affected, then push.  It's faster, usually more correct
(as it checks the final state of all packages), and more flexible
(fixups, anyone?).

If you need something convenient to commit, app-portage/mgorny-dev-
scripts has pkgcommit tool which does the only useful part of what
repoman did -- that is, prepends package name to the commit message. 
For pre-push checks, I use the following oneliner:

$ pkgcheck scan $(git diff origin --name-only $(<profiles/categories) \
    | cut -d/ -f1-2 | sort -u); echo $?

I have it in bash history, and pkgch<pgup> takes care of it.  If people
want, I can add it to mgorny-dev-scripts under some fancy name.

-- 
Best regards,
Michał Górny