Re: [gentoo-dev] [PATCH 1/5] gui-libs/gtk: add a "poison" macro support to disable X/wayland

[Eli Schwartz <eschwartz93@gmail.com>]

[-- Attachment #1.1.1: Type: text/plain, Size: 1098 bytes --]

On 6/26/24 5:03 AM, Sam James wrote:
> Eli Schwartz <eschwartz93@gmail.com> writes:
> 
>> Many packages perform automagic dependencies on gdk's backend
>> implementations by checking if the macro is defined and then using the
>> code it unlocks, rather than having a buildsystem option such as
>> -Dwayland=true.
>>
> Doesn't gtk3 need this too? Also, could we have an upstream report
> making them aware of this for gtk4?


Yes, gtk3 needs this too (and patches in this series depend on it).

At https://github.com/gentoo/gentoo/pull/37259 there are 6 patches, not
5 -- I appear to have accidentally excluded the first patch when sending
it to the list, unsure how that happened. It's almost ccompletely
copy/paste from gtk4.

As far as reporting this upstream goes, I'm somewhat nervous they will
suggest you should simply build against what you use and require what
you build against. It's not a completely unreasonable suggestion, in
fact it's the one I described as option 4 and Gentoo simply cannot use
it today since it would require new EAPI.


-- 
Eli Schwartz

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 18399 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]