[gentoo-dev] pkgdev new release v0.2.1 with breaking change

[gentoo-dev] pkgdev new release v0.2.1 with breaking change

[Arthur Zamarin]

[-- Attachment #1.1: Type: text/plain, Size: 1399 bytes --]

I have just released a new version [0] for pkgdev. Outside of multiple
new features meant for easier developer workflows (like prepare to send
a last-rite email), there is an important changes in the release which
affect current users of pkgdev.

** Important Notice **

pkgdev now doesn't add the signoff by itself, unless configured. You can
easily configure it by following the instructions [1], which in short
corresponds to adding to `~/.config/pkgdev/pkgdev.conf` the lines:

  [gentoo]
  push.signoff = true

In case you forgot to perform this, the usual workflow of working with
pkgdev (meaning committing and then pushing) would seem to work, but
because of missing Signed-off-by line, the push would fail.


I also recommend to read the full configuration docs at [1], as now it
is possible to configure the "new default" args for pkgdev.

Finally I want to call for features requests for the pkgcheck and
pkgdev. Myself and other developers are trying to actively maintain the
stack, and add new features, QA checks, etc. I want to make those tools
nice for Gentoo developers, so I need your requests to improve it.

[0] https://github.com/pkgcore/pkgdev/releases/tag/v0.2.1
[1] https://pkgcore.github.io/pkgdev/man/pkgdev.html#config-file-support

-- 
Arthur Zamarin
arthurzam@gentoo.org
Gentoo Linux developer (Python, Arch Teams, pkgcore stack, GURU)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[gentoo-dev] Re: pkgdev new release v0.2.1 with breaking change

[Andrew Ammerlaan]

On 22/05/2022 20:20, Arthur Zamarin wrote:
> I have just released a new version [0] for pkgdev. Outside of multiple
> new features meant for easier developer workflows (like prepare to send
> a last-rite email), there is an important changes in the release which
> affect current users of pkgdev.
> 
> ** Important Notice **
> 
> pkgdev now doesn't add the signoff by itself, unless configured. You can
> easily configure it by following the instructions [1], which in short
> corresponds to adding to `~/.config/pkgdev/pkgdev.conf` the lines:
> 
>    [gentoo]
>    push.signoff = true

Shouldn't this be commit.signoff instead?

pkgdev push: failed loading config: unknown arguments: --signoff=true

(The same mistake is in the documentation at [1])

> In case you forgot to perform this, the usual workflow of working with
> pkgdev (meaning committing and then pushing) would seem to work, but
> because of missing Signed-off-by line, the push would fail.
> 
> 
> I also recommend to read the full configuration docs at [1], as now it
> is possible to configure the "new default" args for pkgdev.
> 
> Finally I want to call for features requests for the pkgcheck and
> pkgdev. Myself and other developers are trying to actively maintain the
> stack, and add new features, QA checks, etc. I want to make those tools
> nice for Gentoo developers, so I need your requests to improve it.
> 
> [0] https://github.com/pkgcore/pkgdev/releases/tag/v0.2.1
> [1] https://pkgcore.github.io/pkgdev/man/pkgdev.html#config-file-support
> 

Best regards,
Andrew

Re: [gentoo-dev] Re: pkgdev new release v0.2.1 with breaking change

[Arthur Zamarin]

[-- Attachment #1.1: Type: text/plain, Size: 1396 bytes --]

On 23/05/2022 20.57, Andrew Ammerlaan wrote:
> On 22/05/2022 20:20, Arthur Zamarin wrote:
>> I have just released a new version [0] for pkgdev. Outside of multiple
>> new features meant for easier developer workflows (like prepare to send
>> a last-rite email), there is an important changes in the release which
>> affect current users of pkgdev.
>>
>> ** Important Notice **
>>
>> pkgdev now doesn't add the signoff by itself, unless configured. You can
>> easily configure it by following the instructions [1], which in short
>> corresponds to adding to `~/.config/pkgdev/pkgdev.conf` the lines:
>>
>>    [gentoo]
>>    push.signoff = true
> 
> Shouldn't this be commit.signoff instead?
> 
> pkgdev push: failed loading config: unknown arguments: --signoff=true
> 
> (The same mistake is in the documentation at [1])
> 
>> ...
> 
> Best regards,
> Andrew
> 

Thank you Andrew, You are absolutely right - this was my mistake in
lines. It should be:

  [gentoo]
  commit.signoff = true

Actually I also got reports of it failing to identify that this is the
gentoo repo, so for now, so we are absolutely sure it works, please use:

  [DEFAULT]
  commit.signoff = true

Once again, I'm sorry for this mistake, and I will fix the docs ASAP.

-- 
Arthur Zamarin
arthurzam@gentoo.org
Gentoo Linux developer (Python, Arch Teams, pkgcore stack, GURU)

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [gentoo-dev] Feature request for pkgcheck (was: pkgdev new release v0.2.1 with breaking change)

[Anna V]

I'd like pkgcheck to detect if RDEPEND was changed without revbump.

Re: [gentoo-dev] Feature request for pkgcheck (was: pkgdev new release v0.2.1 with breaking change)

[Sam James]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]



> On 5 Jun 2022, at 00:34, Anna V <cyber+gentoo@sysrq.in> wrote:
> 
> I'd like pkgcheck to detect if RDEPEND was changed without revbump.
> 

pkgcheck scan --commits does. A solution for when _other_ people did this could be
done by diffing metadata, I think.

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]

Re: [gentoo-dev] Feature request for pkgdev (was: pkgdev new release v0.2.1 with breaking change)

[Anna V]

git-send-email wrapper that CCs package/eclass maintainers automatically