From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9176915802F for ; Thu, 9 Mar 2023 05:56:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C5991E08EC; Thu, 9 Mar 2023 05:56:18 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 84329E08C4 for ; Thu, 9 Mar 2023 05:56:18 +0000 (UTC) Message-ID: <15df2c2fa369a6589b42fe406947ee52cb67b8e3.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: Use gemato openpgp-verify-detached w/ 20.0+ From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Thu, 09 Mar 2023 06:56:14 +0100 In-Reply-To: <20230308225412.5414f3c8@zen> References: <20230308163324.10644-1-mgorny@gentoo.org> <20230308225412.5414f3c8@zen> Organization: Gentoo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: ba773f77-a518-4b1c-844d-b40faf27496b X-Archives-Hash: 0d5fb24a73b2b209cfcd9a13ab5e8145 On Wed, 2023-03-08 at 22:54 +0000, Sam James wrote: > On Wed, 8 Mar 2023 17:33:24 +0100 > Micha=C5=82 G=C3=B3rny wrote: >=20 > > Use openpgp-verify-detached when app-portage/gemato-20.0 is installed. > > This lets us test the new code paths on ~arch with minimal risk > > of breakage on stable. > >=20 > > Signed-off-by: Micha=C5=82 G=C3=B3rny > > --- > > eclass/verify-sig.eclass | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > >=20 > > This is roughly the same patch that I've sent before, except that now > > it features a has_version condition to restrict the changes to ~arch > > gemato version. > >=20 > > diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass > > index 91433bf53453..f67a3b10a0bf 100644 > > --- a/eclass/verify-sig.eclass > > +++ b/eclass/verify-sig.eclass > > @@ -144,9 +144,16 @@ verify-sig_verify_detached() { > > # gpg can't handle very long TMPDIR > > # https://bugs.gentoo.org/854492 > > local -x TMPDIR=3D/tmp > > - gemato gpg-wrap -K "${key}" > > "${extra_args[@]}" -- \ > > - gpg --verify "${sig}" "${file}" || > > - die "PGP signature verification > > failed" > > + if has_version -b ">=3Dapp-portage/gemato-20"; >=20 > Do we want to log when taking this path temporarily? >=20 I don't think it's necessary, the output is clearly distinguishable. --=20 Best regards, Micha=C5=82 G=C3=B3rny