public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Andrew Ammerlaan <andrewammerlaan@riseup.net>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3] dev-python/tikzplotlib: Use distutils-r1 pyproject.toml support
Date: Sat, 6 Feb 2021 14:23:37 +0100	[thread overview]
Message-ID: <1562d939-cf07-7cc5-47d4-0648c3829176@riseup.net> (raw)
In-Reply-To: <20210206115408.118297-2-mgorny@gentoo.org>

On 06/02/2021 12:54, Michał Górny wrote:
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>   dev-python/tikzplotlib/tikzplotlib-0.9.7.ebuild | 16 +---------------
>   1 file changed, 1 insertion(+), 15 deletions(-)
> 
> diff --git a/dev-python/tikzplotlib/tikzplotlib-0.9.7.ebuild b/dev-python/tikzplotlib/tikzplotlib-0.9.7.ebuild
> index b1d6c8827e1d..eec9580243fc 100644
> --- a/dev-python/tikzplotlib/tikzplotlib-0.9.7.ebuild
> +++ b/dev-python/tikzplotlib/tikzplotlib-0.9.7.ebuild
> @@ -3,6 +3,7 @@
>   
>   EAPI=7
>   
> +DISTUTILS_USE_SETUPTOOLS=pyproject.toml
>   PYTHON_COMPAT=( python3_{7..9} )
>   
>   inherit distutils-r1 virtualx
> @@ -35,21 +36,6 @@ BDEPEND="
>   distutils_enable_tests pytest
>   distutils_enable_sphinx doc dev-python/mock
>   
> -python_prepare_all() {
> -	# setup.py was removed in commit f04323cfa575caf8a25a9236f55fe6baf1a33b20
> -	# for some reason, DISTUTULS_USE_SETUPTOOLS="pyproject.toml" is not working
> -	# it complains about file not found, setup.cfg does exist
> -
> -	cat > setup.py <<EOF || die
> -from setuptools import setup
> -
> -if __name__ == "__main__":
> -	setup()
> -EOF
> -
> -	distutils-r1_python_prepare_all
> -}
> -
>   python_test() {
>   	local -x MPLBACKEND=Agg
>   	virtx pytest -vv
> 

Looks good to me

Thank you mgorny



  reply	other threads:[~2021-02-06 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-06 11:54 [gentoo-dev] [PATCH 1/3] distutils-r1.eclass: Fix setuptools without setup.py Michał Górny
2021-02-06 11:54 ` [gentoo-dev] [PATCH 2/3] dev-python/tikzplotlib: Use distutils-r1 pyproject.toml support Michał Górny
2021-02-06 13:23   ` Andrew Ammerlaan [this message]
2021-02-06 11:54 ` [gentoo-dev] [PATCH 3/3] distutils-r1.eclass: Require EPYTHON to be set Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1562d939-cf07-7cc5-47d4-0648c3829176@riseup.net \
    --to=andrewammerlaan@riseup.net \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox