public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-libs/libssh2/
Date: Mon, 01 Oct 2018 22:04:43 +0200	[thread overview]
Message-ID: <1538424283.1095.20.camel@gentoo.org> (raw)
In-Reply-To: <20181001213046.2b29922f@wim.jer>

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On Mon, 2018-10-01 at 21:30 +0200, Jeroen Roovers wrote:
> On Mon, 01 Oct 2018 17:00:24 +0200
> Michał Górny <mgorny@gentoo.org> wrote:
> 
> > So your src_compile() is now broken for Ninja users, and src_test()
> > is broken altogether.  How about cmake-multilib eclass?
> 
> DROP
> 
> > IUSE=test is not used at all.
> 
> THAT
> 
> > By the way, MULTILIB_USEDEP certainly missing here.
> 
> BLOODY
> 
> > You sure this autoconf patch is needed for CMake build?
> 
> AWFUL
> 
> > They must have hacked that CMake hard to get it to generate .la files.
> 
> ATTITUTE

Since I've been approached by developers asking me about the original
mail missing in the archives, I would like to note that I didn't send it
to this mailing list.  My purpose was to ask him to improve the ebuild
and not publicly point out his mistakes.

The choice of posting a reply to gentoo-dev was entirely his decision.

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

  parent reply	other threads:[~2018-10-01 20:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1538394370.d866d4705e1e4a092579a31df2815e3407950a19.jer@gentoo>
     [not found] ` <1538406024.1095.4.camel@gentoo.org>
2018-10-01 19:30   ` [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-libs/libssh2/ Jeroen Roovers
2018-10-01 19:41     ` Michał Górny
2018-10-01 20:04     ` Michał Górny [this message]
2018-10-01 21:13   ` Jeroen Roovers
2018-10-01 21:43     ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538424283.1095.20.camel@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox