Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-libs/libssh2/

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 993 bytes --]

On Mon, 2018-10-01 at 21:30 +0200, Jeroen Roovers wrote:
> On Mon, 01 Oct 2018 17:00:24 +0200
> Michał Górny <mgorny@gentoo.org> wrote:
> 
> > So your src_compile() is now broken for Ninja users, and src_test()
> > is broken altogether.  How about cmake-multilib eclass?
> 
> DROP
> 
> > IUSE=test is not used at all.
> 
> THAT
> 
> > By the way, MULTILIB_USEDEP certainly missing here.
> 
> BLOODY
> 
> > You sure this autoconf patch is needed for CMake build?
> 
> AWFUL
> 
> > They must have hacked that CMake hard to get it to generate .la files.
> 
> ATTITUTE

Then please kindly improve the quality of your Gentoo work.  Ebuild
writing is more than copying files and doing the minimal change
necessary for it not to explode in your face.

Furthermore, I don't really understand why you're CC-ing netmon@ here. 
Given you've cut off all the context, my suggestions would seem rather
meaningless to the other member.

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]