From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 070D2138334 for ; Fri, 21 Sep 2018 16:03:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C0201E0874; Fri, 21 Sep 2018 16:03:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 69EACE07B2 for ; Fri, 21 Sep 2018 16:02:59 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id D6FD0335D08; Fri, 21 Sep 2018 16:02:57 +0000 (UTC) Message-ID: <1537545773.926.1.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] eclass/waf-utils.eclass: add parameters to compile and install From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Fri, 21 Sep 2018 18:02:53 +0200 In-Reply-To: <20180921185142.5a665ece@bkstv.local> References: <20180921185142.5a665ece@bkstv.local> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fen1lmPPl3glWcSufLXA" X-Mailer: Evolution 3.26.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: e8ef02f6-7a69-43e0-b211-9867bf6b5a3c X-Archives-Hash: 558ea3f72e1e54cdb12809aed5b1950c --=-fen1lmPPl3glWcSufLXA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2018-09-21 at 18:51 +0300, Victor Kustov wrote: > [1] https://github.com/gentoo/gentoo/pull/9533#discussion_r211739558 >=20 > This patch add parameters to compile and install phases in waf-utils > eclass. Need to solve [1] >=20 > --- > eclass/waf-utils.eclass | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/eclass/waf-utils.eclass b/eclass/waf-utils.eclass > index 4d02483a927..33515b883b5 100644 > --- a/eclass/waf-utils.eclass > +++ b/eclass/waf-utils.eclass > @@ -102,8 +102,8 @@ waf-utils_src_compile() { > [[ ${WAF_VERBOSE} =3D=3D ON ]] && _mywafconfig=3D"--verbose" > =20 > local jobs=3D"--jobs=3D$(makeopts_jobs)" > - echo "\"${WAF_BINARY}\" build ${_mywafconfig} ${jobs}" > - "${WAF_BINARY}" ${_mywafconfig} ${jobs} || die "build failed" > + echo "\"${WAF_BINARY}\" $@ build ${_mywafconfig} ${jobs}" > + "${WAF_BINARY}" $@ ${_mywafconfig} ${jobs} || die "build failed" "${@}" i.e. quote it or this is going to spew into a mess. > } > =20 > # @FUNCTION: waf-utils_src_install > @@ -112,8 +112,8 @@ waf-utils_src_compile() { > waf-utils_src_install() { > debug-print-function ${FUNCNAME} "$@" > =20 > - echo "\"${WAF_BINARY}\" --destdir=3D\"${D}\" install" > - "${WAF_BINARY}" --destdir=3D"${D}" install || die "Make install failed= " > + echo "\"${WAF_BINARY}\" --destdir=3D\"${D}\" \"$@\" install" > + "${WAF_BINARY}" --destdir=3D"${D}" "$@" install || die "Make install f= ailed" Likewise. > =20 > # Manual document installation > einstalldocs --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-fen1lmPPl3glWcSufLXA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAlulFi5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI EQoRqhAAqa2+KGcO2adzMA1wp0/fjC1Phf3mWNCiL+91SHqqeY6zCqQ8egCtxxKR L3yfcC+APzQ89c32RsL5GWwAzgpsmidP1Bie/s6DxTB+6QeIsLFAsWu85EEvmVJt r7h8vkz4AgfoAiVVIn0uCjDUEfF+XPXuvRbM4wjsygSbF9/5ZNLjqiB3Hvy0MffS gvcdlQGoq85VYmFE+TWZQoTABqco4qvJHEODuWy06w1gkwUXvcUIas0DthWXYcGC jQmajrr69uODF0QqLTc9SD9zQDUfqX9ZGkLAY8owmOO8IPWwURGsZN0Uj7bM7a7c uTvErKboSlJIzG9DcPuQtaK4cCeDKm/AON6T7C/BlMMjslLP5b3xqlGtyFg8TfEg JGqy7BU1VHvRF90byCh8E9NCEO23IqYDCTSOzsPO2ASh817Eit25nnlnI59nCS9d Ikl1Zt3gxxf03zkolZUHxuvNL8g8hYU6PrhKH/RTEiqh+CS8R88+2dnINHlsF6Z5 7/p6/iBL1gu7z4msXRztRxY59Jywhhg8dhqM645d4t/BfvkD3KReRKCX9hwVGClZ bW1TmOBGv9KaezahxDrnCQzWncpT4yAhcjjl8R1zCt2i4So+zLL7KjJd7h0MzfXI FUrdEEw0LgHt/S/gh5Gf+TNBDeY+MGJuATLIheuSl0jqV5uUFhg= =p+28 -----END PGP SIGNATURE----- --=-fen1lmPPl3glWcSufLXA--