From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] eclass/waf-utils.eclass: add parameters to compile and install
Date: Fri, 21 Sep 2018 18:02:53 +0200 [thread overview]
Message-ID: <1537545773.926.1.camel@gentoo.org> (raw)
In-Reply-To: <20180921185142.5a665ece@bkstv.local>
[-- Attachment #1: Type: text/plain, Size: 1562 bytes --]
On Fri, 2018-09-21 at 18:51 +0300, Victor Kustov wrote:
> [1] https://github.com/gentoo/gentoo/pull/9533#discussion_r211739558
>
> This patch add parameters to compile and install phases in waf-utils
> eclass. Need to solve [1]
>
> ---
> eclass/waf-utils.eclass | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/eclass/waf-utils.eclass b/eclass/waf-utils.eclass
> index 4d02483a927..33515b883b5 100644
> --- a/eclass/waf-utils.eclass
> +++ b/eclass/waf-utils.eclass
> @@ -102,8 +102,8 @@ waf-utils_src_compile() {
> [[ ${WAF_VERBOSE} == ON ]] && _mywafconfig="--verbose"
>
> local jobs="--jobs=$(makeopts_jobs)"
> - echo "\"${WAF_BINARY}\" build ${_mywafconfig} ${jobs}"
> - "${WAF_BINARY}" ${_mywafconfig} ${jobs} || die "build failed"
> + echo "\"${WAF_BINARY}\" $@ build ${_mywafconfig} ${jobs}"
> + "${WAF_BINARY}" $@ ${_mywafconfig} ${jobs} || die "build failed"
"${@}" i.e. quote it or this is going to spew into a mess.
> }
>
> # @FUNCTION: waf-utils_src_install
> @@ -112,8 +112,8 @@ waf-utils_src_compile() {
> waf-utils_src_install() {
> debug-print-function ${FUNCNAME} "$@"
>
> - echo "\"${WAF_BINARY}\" --destdir=\"${D}\" install"
> - "${WAF_BINARY}" --destdir="${D}" install || die "Make install failed"
> + echo "\"${WAF_BINARY}\" --destdir=\"${D}\" \"$@\" install"
> + "${WAF_BINARY}" --destdir="${D}" "$@" install || die "Make install failed"
Likewise.
>
> # Manual document installation
> einstalldocs
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2018-09-21 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 15:51 [gentoo-dev] [PATCH] eclass/waf-utils.eclass: add parameters to compile and install Victor Kustov
2018-09-21 16:02 ` Michał Górny [this message]
2018-09-22 12:55 ` Victor K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537545773.926.1.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox