From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6303A138334 for ; Sun, 9 Sep 2018 16:11:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E5673E09AB; Sun, 9 Sep 2018 16:11:47 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8696DE09A6 for ; Sun, 9 Sep 2018 16:11:47 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 29D64335D44; Sun, 9 Sep 2018 16:11:44 +0000 (UTC) Message-ID: <1536509500.863.0.camel@gentoo.org> Subject: Re: [gentoo-dev] Changing policy about -Werror From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Sun, 09 Sep 2018 18:11:40 +0200 In-Reply-To: <79F8E956-12C7-4C96-A029-106B785294B3@gentoo.org> References: <20180909143221.21d784d02f51623e8c57c545@gentoo.org> <79F8E956-12C7-4C96-A029-106B785294B3@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-++M63x8I20UEYb5ul7JR" X-Mailer: Evolution 3.24.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: a2609684-1e72-4a77-892c-91bb9da6144d X-Archives-Hash: 550c4410392c7b9b4cd4825763c96cf1 --=-++M63x8I20UEYb5ul7JR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2018-09-09 at 11:22 -0400, Richard Yao wrote: > > On Sep 9, 2018, at 7:32 AM, Andrew Savchenko wrote= : > >=20 > > Hi! > >=20 > > Our current -Werror policy demands unconditional removal: > > https://devmanual.gentoo.org/ebuild-writing/common-mistakes/index.html#= -werror-compiler-flag-not-removed > >=20 > > I think this is wrong, see bugs 665464, 665538 for a recent > > discussion why. > >=20 > > My point is that in *most* cases -Werror indeed should be removed, > > because upstream rarely can keep up with all possible configure, > > *FLAGS, compiler versions and arch combinations. But! In some cases > > =E2=80=94 especially for security oriented software =E2=80=94 this flag= may be > > pertain and may be kept at maintainer's discretion. > >=20 > > The rationale is that -Werror usually points to dangerous > > situations like uninitialized variables, pointer type mismatch or > > implicit function declaration (and much more) which may lead to > > serious security implications. > >=20 > > So, if maintainer has enough manpower to support this flag, we > > should allow to keep it. Of course if it will cause long-standing > > troubles (e.g. bugs opened for a long time) QA should have power to > > remove it or demand its removal. > >=20 > > So my proposal is: > >=20 > > 1) Deprecate QA policy with unconditional demand of -Werror removal. > > 2) Add to devmanual's chapter on -Werror an exception clause about > > security-oriented software and maintainer's right to make final > > decision. >=20 > -Werror has caught bugs that could have resulted in data loss in ZFS in t= he past thanks to it being built in userspace as part of zdb. So it is usef= ul for integrity too, not just security (although arguably, integrity is pa= rt of security). >=20 > Currently, sys-fs/zfs turns on -Werror when USE=3Ddebug is set. So far, n= obody has complained about USE=3Ddebug enforcing -Werror. USE=3Ddebug by de= finition ought to be an exception. Now that you know that you're violating a policy, please kindly fix that. > Perhaps we could have another USE flag for -Werror where it is a security= feature. e.g. USE=3Dstrict-compile-checks Perhaps people could learn that Gentoo lets them alter CFLAGS, and stop inventing USE flags for every flag the compiler supports. > >=20 > > Best regards, > > Andrew Savchenko >=20 >=20 --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-++M63x8I20UEYb5ul7JR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAluVRjxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI EQrFJxAAiHZ42fezBacmHB+KlhQOhy7PaYHYbNDQNW+XGjp12SwnVQg4KB4/AiK8 S+IuCarVptIttyKZzM9kvR4Ewz+esNhX9dffRxLjc7oB0kBbPdZ4P2rJg7vB38Af h144TGH+z6PBV/G3i0b/2py43FBgJigOtct3sAcHAhpGkvvUQPtuvWheBpVqHkG4 +MOx5I6siQCWo+LR4kVqAE8kH+aGzrTHRS1sX4ad/zN8Xua4Ai0gik6d/JazeZ/V x9vhEKolf0DOfO+b/iugDn5ermwAp3PIUCRQR1zVT38It9LoELbVTB0F8U/bGp7z a1+Oqy/HVhbYRSZGTFwHQAMMrJzGy4ibmvdOo9X014Q/GZKoUeltU02/5zbzl1ov 8UCaZRt4TgfgpRLOtqlfmxTkhjz0GPqNkcMWV9UFX5qK5sZmxz9nF5BonJ/Sr3LM IlwpUfwMIUuQPavyzGy/jwZWQJWkdwApQS72GPcou3focevFITILD1jDt2Hzw+Ip pUTix7WO6mgZ7zwT6O7Z0EbY3URfmU/vkK2vPzm/vor8PaI+qW+ajIjOGg/OEGZL EAdoco17MCkcmmsBztIKSz5NDuyt7bS7kMBrdTVdmGR17pGtZ/jF2ESONlBPtXTn lmanf1YbneEKVREq0t0FvFQL03YjNE7K1po7OR+ZV2O88rdkudM= =ZYDs -----END PGP SIGNATURE----- --=-++M63x8I20UEYb5ul7JR--