From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 483D2138334 for ; Thu, 26 Jul 2018 07:21:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 05FCDE087D; Thu, 26 Jul 2018 07:21:52 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7372FE0830 for ; Thu, 26 Jul 2018 07:21:50 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 29656335CC2; Thu, 26 Jul 2018 07:21:47 +0000 (UTC) Message-ID: <1532589703.730.2.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/2] cmake-utils.eclass: Make ninja default backend in EAPI >= 7 From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: David Seifert Date: Thu, 26 Jul 2018 09:21:43 +0200 In-Reply-To: <20180726063501.18702-1-soap@gentoo.org> References: <20180726063501.18702-1-soap@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-IXqzgfAONHdwowMfp1CF" X-Mailer: Evolution 3.24.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 041ab597-fdeb-48a5-9d2a-4b4bdd1ebfc3 X-Archives-Hash: 72e8a90ca36c1004e60bf136909e49fb --=-IXqzgfAONHdwowMfp1CF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable W dniu czw, 26.07.2018 o godzinie 08=E2=88=B635=E2=80=89+0200, u=C5=BCytkow= nik soap@gentoo.org napisa=C5=82: > From: David Seifert >=20 > * Using the ninja backend as a default is the only way to > massively improve src_compile core utilization, given that > it seems unlikely that CMake will ever produce non-recursive > Makefiles. >=20 > For a benchmark, see: > http://www.kaizou.org/2016/09/build-benchmark-large-c-project/ For the record, 'core utilization' or speed in general is a poor argument. You shouldn't have brought it because it will bring completely unnecessary bikeshed to this thread. Gentoo developers will argue about it not because it could benefit Gentoo in any way but because someone is wrong on the Internet! The primary reason for using Ninja is making verbose build output readable, in particular getting a lot of pointless nested verbose echos out of it. > --- > eclass/cmake-utils.eclass | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) >=20 > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass > index e64502b3b9b..ed81426ddcc 100644 > --- a/eclass/cmake-utils.eclass > +++ b/eclass/cmake-utils.eclass > @@ -53,7 +53,8 @@ _CMAKE_UTILS_ECLASS=3D1 > # @DESCRIPTION: > # Specify a makefile generator to be used by cmake. > # At this point only "emake" and "ninja" are supported. > -: ${CMAKE_MAKEFILE_GENERATOR:=3Demake} > +# In EAPI 7 and above, the default is set to "ninja", > +# whereas in EAPIs below 7, it is set to "emake". > =20 > # @ECLASS-VARIABLE: CMAKE_MIN_VERSION > # @DESCRIPTION: > @@ -112,8 +113,13 @@ esac > inherit toolchain-funcs ninja-utils flag-o-matic multiprocessing xdg-uti= ls > =20 > case ${EAPI} in > - 7) ;; > - *) inherit eapi7-ver eutils multilib ;; > + [56]) > + : ${CMAKE_MAKEFILE_GENERATOR:=3Demake} > + inherit eapi7-ver eutils multilib > + ;; > + *) > + : ${CMAKE_MAKEFILE_GENERATOR:=3Dninja} > + ;; > esac > =20 > EXPORT_FUNCTIONS src_prepare src_configure src_compile src_test src_inst= all --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-IXqzgfAONHdwowMfp1CF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEbbsHzE8NrQbqCv5BsHoa6u+0Rk4FAltZdohfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDZE QkIwN0NDNEYwREFEMDZFQTBBRkU0MUIwN0ExQUVBRUZCNDQ2NEUACgkQsHoa6u+0 Rk5wBRAA4VgkF9LMdBo0qfgvJ1FA+nIy5eAnx46jqZQMT97PbzXojKjM9u4iQ2+D OaeuaKwQrfyvDktI3zKzjuRWNMP49jV6CZOCPdEMdeC1WJojtaCLWVUvOxEomxcF TFaf0s/53ud2qA8U+p8Dp7uawn/toLPqvMFZ02L/HHgR6u/SniSBaZUFYsCjoFhz kRJkeuK7uLaR8WTzrXNF7Mmcq5DC9F1TdHj+aJSfN+U3kly2ndMohAwzBZEHxb0P 2tUfb7BFe14OK4KQW5VMRwIW59fnf1778oMCSi1dM02wZdfNDq6NNbuXiXz6MgRL dE35oH4xJe89rzxtrncie72Cla8c2vqt+slcDsLsCSvynkB358svKH+DE5w3q5r7 hdED/k7CKT9dYGpWUlN6jk/2enX5z941JDpIdbENSnYzyzNiW4acNujSWLFvCvSw Rf1tyJD/3vB5ntHB4Rk0SBpXFppHB72hPxPIA5iGYIFmqyQLlP78Xm1/kuqZKB1F vfaFDoi0wK2O29uW/NA/AmSQ6L5dLYoc3GpKzO5vPePC5QrJDiYJ7+/mf5kHZ3zP 43ArL3Vl6gopRIiYEKlsOwp1oxB1kDeQ/862mvFtohL5isqtY3+BbMY6LU/DmN3W Ea//XAtU0wpfUpygkengFcbqMVds9+pW+QrIG6PjE16qFSdgXbE= =sxSt -----END PGP SIGNATURE----- --=-IXqzgfAONHdwowMfp1CF--