[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-python/python-axolotl/

[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-python/python-axolotl/

[Michał Górny]

[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]

Hanno,

W dniu pią, 22.06.2018 o godzinie 17∶39 +0000, użytkownik Hanno Boeck
napisał:
> commit:     acdbda5cb244963b4b7982d96d0538760a385a4d
> Author:     Hanno <hanno <AT> gentoo <DOT> org>
> AuthorDate: Fri Jun 22 17:39:08 2018 +0000
> Commit:     Hanno Boeck <hanno <AT> gentoo <DOT> org>
> CommitDate: Fri Jun 22 17:39:08 2018 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=acdbda5c
> 
> dev-python/python-axolotl: Initial commit.
> 
> Python support for the Axolotl protocol (used by OMEMO).
> 
> Closes: https://bugs.gentoo.org/608882
> Closes: https://github.com/gentoo/gentoo/pull/7778
> Package-Manager: Portage-2.3.40, Repoman-2.3.9
> 
>  dev-python/python-axolotl/Manifest                 |  1 +
>  dev-python/python-axolotl/metadata.xml             | 11 +++++++++++
>  .../python-axolotl/python-axolotl-0.1.42.ebuild    | 23 ++++++++++++++++++++++
>  3 files changed, 35 insertions(+)
> 
> 
> [...]

> +DEPEND="dev-python/python-axolotl-curve25519[${PYTHON_USEDEP}]
> +	dev-python/cryptography[${PYTHON_USEDEP}]
> +	dev-python/protobuf-python[${PYTHON_USEDEP}]
> +	dev-python/setuptools[${PYTHON_USEDEP}]"

While I really appreciate the willingness to help proxy-maint with
the lot of work we have, I'd really appreciate if you tried to be more
careful about what you're doing and respectful to the team policies.

I have to point out that:

1. You're not on the team or the alias, so that's basically a 'dump off'
commit that we will have to fix for you.

2. You've merged a pull request that was still during review by me,
8 hours after I have *requested changes* and without giving me a chance
to verify that the changes has been made.

3. You've merged an *old version* of the pull request rather than
the newest commits...

4. ...and effectively, you've merged ebuild with a lot of mistakes
and disregarded proxied maintainer's work to fix them; which also means
you didn't properly review/test what you were merging.

So while help is appreciated, please learn how proxy-maint operates
and double-check what you are doing.  I have reverted both commits.

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]