From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1SXg7Q-0005i7-8R for garchives@archives.gentoo.org; Thu, 24 May 2012 22:02:52 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 36704E07D0; Thu, 24 May 2012 22:02:37 +0000 (UTC) Received: from mail-ob0-f181.google.com (mail-ob0-f181.google.com [209.85.214.181]) by pigeon.gentoo.org (Postfix) with ESMTP id 0AFFEE05F1 for ; Thu, 24 May 2012 22:01:56 +0000 (UTC) Received: by obbuo19 with SMTP id uo19so349099obb.40 for ; Thu, 24 May 2012 15:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=pCIaUQOqzJgL3iybTXMuPQ+HyWhi+A7+OyJcKObV7no=; b=lBt4sTMiPVgUFVLsNGYMxAiyoKhaMvx+BvASKX9kAbIVOZB9K+60bjl5ZA75dI756V dQ3vaf/YI+71N9AxbwcLlq2TkDscXRkGjzbQKjCMyr4+xUssn7k/ljlWHKj5Kz5Ch9j5 qlTyJA5ZPuZfeRLNfQMOJLMpbCxripVrd2/8LLOJqpdroe7sgWa0BEhAgCG21nUHU98g phMN/CYukILt/uT0f2+L8Qz2ZQt0IDa6nu1m9P3jBhFB6B3vMP5MhSOMlSlu0as9s5gv GV/ncDp6cOgyNF55g49wJuxnlRvLHcZCuZs3c2AvP6DO0fydpyiFQWEuDtZ1LF2+kHY2 q01g== Received: by 10.182.14.100 with SMTP id o4mr973368obc.23.1337896916414; Thu, 24 May 2012 15:01:56 -0700 (PDT) Received: from smorgbox.localnet (65-128-181-111.mpls.qwest.net. [65.128.181.111]) by mx.google.com with ESMTPS id o4sm447317oef.11.2012.05.24.15.01.54 (version=SSLv3 cipher=OTHER); Thu, 24 May 2012 15:01:55 -0700 (PDT) From: Dan Douglas To: gentoo-dev@lists.gentoo.org Cc: "Aaron W. Swenson" Subject: Re: [gentoo-dev] Portage Git migration - Handling Pull Requests (Was: clean cut or git-cvsserver) Date: Thu, 24 May 2012 17:01:43 -0500 Message-ID: <1520922.mmjlWrWcEL@smorgbox> User-Agent: KMail/4.8.3 (Linux/3.3.6-pf+; KDE/4.8.3; x86_64; ; ) In-Reply-To: <4FBEA181.30204@gentoo.org> References: <4FBCDB3D.1070009@gentoo.org> <3485389.iLMx13MNW5@smorgbox> <4FBEA181.30204@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart60832850.u9fc4JrtkX"; micalg="pgp-sha1"; protocol="application/pgp-signature" Content-Transfer-Encoding: 7Bit X-Archives-Salt: 8b46dda7-96d5-46b1-8e9a-344a6a008885 X-Archives-Hash: e2219ef3f08c1677358373e1d1bc5ea2 --nextPart60832850.u9fc4JrtkX Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Thursday, May 24, 2012 05:00:49 PM Aaron W. Swenson wrote: > This gets us into another topic altogether. > > I do believe git pull-requests should go through Bugzilla. A > pull-request is the equivalent to bump requests, patch fixes, and all > sorts of stuff that we already handle through Bugzilla. Bugzilla also > contains our history. This discussion was sort of in the context of proxy-maintainers. A pull request isn't equivalent to a bump request or entirely overlapping with most bugs that go through bugzilla. A pull request is just "here take my code", or is useful for code revewing just because it integrates with the git workflow. I suppose you would have to define the sorts of things that should go through Bugzilla. I can't imagine it being reasonable to use github for most types of bump requests. > If they happen to be needing to be pulled from github, that's fine. > Definitely convenient for the contributor. > > We'll also need to clearly document how the pull-request is to be > generated. (I vote for requiring signed pull-requests. [1]) > > github should not be our central point of contact. We have b.g.o for > that. github should be on the fringes as a tool that we can use if we > want to. This reminds me of Linus' old Google talk on Git in which He said something along the lines of: "Many companies using Git internally don't know they're using git - they're using it whether they like it or not". There are ALREADY Gentoo projects using github and even pull requests. It doesn't really matter because everything more or less comes back to one point in the end. It's the repo that's the history of the project, not bugzilla. I've "filed" more bugs over IRC and had them fixed in the tree within 60 seconds than I have gone through bugzilla formalisms. FWIW, I think having the entire tree in one big repo is a bad idea to begin with. But ok it's a good point. Github isn't a good central point of contact. People have to use their discression. It's just uncommon these days for a project as big as Gentoo to have ultra-centralized corporate-style procedures where everything happens exclusively though official channels. And anyway you couldn't "enforce" that sort of thing if you tried. > [1] > http://git-blame.blogspot.com.ar/2012/01/using-signed-tag-in-pull-requests.h > tml -- Dan Douglas --nextPart60832850.u9fc4JrtkX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEABECAAYFAk++r8wACgkQMmyDamdg+Mw8qwCeJunBAfHF2H3SQddCDVpkNOgU BmkAoIzOsPTi4Y7n8QS2bLviak1Rlvrt =gX+2 -----END PGP SIGNATURE----- --nextPart60832850.u9fc4JrtkX--