Re: [gentoo-dev] Portage Git migration - Handling Pull Requests (Was: clean cut or git-cvsserver)

[Dan Douglas <ormaaj@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2356 bytes --]

On Thursday, May 24, 2012 05:00:49 PM Aaron W. Swenson wrote:
> This gets us into another topic altogether.
> 
> I do believe git pull-requests should go through Bugzilla. A
> pull-request is the equivalent to bump requests, patch fixes, and all
> sorts of stuff that we already handle through Bugzilla. Bugzilla also
> contains our history.

This discussion was sort of in the context of proxy-maintainers. A pull 
request isn't equivalent to a bump request or entirely overlapping with most 
bugs that go through bugzilla. A pull request is  just "here take my code", or 
is useful for code revewing just because it integrates with the git workflow. I 
suppose you would  have to define the sorts of things that should go through 
Bugzilla. I can't imagine it being reasonable to use github for most types of 
bump requests.

> If they happen to be needing to be pulled from github, that's fine.
> Definitely convenient for the contributor.
> 
> We'll also need to clearly document how the pull-request is to be
> generated. (I vote for requiring signed pull-requests. [1])
> 
> github should not be our central point of contact. We have b.g.o for
> that. github should be on the fringes as a tool that we can use if we
> want to.

This reminds me of Linus' old Google talk on Git in which He said something 
along the lines of: "Many companies using Git internally don't know they're 
using git - they're using it whether they like it or not". There are ALREADY 
Gentoo projects using github and even pull requests. It doesn't really matter 
because everything more or less comes back to one point in the end. It's the 
repo that's the history of the project, not bugzilla. I've "filed" more bugs 
over IRC and had them fixed in the tree within 60 seconds than I have gone 
through bugzilla formalisms. FWIW, I think having the entire tree in one big 
repo is a bad idea to begin with.

But ok it's a good point. Github isn't a good central point of contact. People 
have to use their discression. It's just uncommon these days for a project as 
big as Gentoo to have ultra-centralized corporate-style procedures where 
everything happens exclusively though official channels. And anyway you couldn't 
"enforce" that sort of thing if you tried.

> [1]
> http://git-blame.blogspot.com.ar/2012/01/using-signed-tag-in-pull-requests.h
> tml

-- 
Dan Douglas

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]