From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5D7CD1382C5 for ; Thu, 15 Feb 2018 01:16:34 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0D933E09E7; Thu, 15 Feb 2018 01:16:28 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id AE6B9E09CF for ; Thu, 15 Feb 2018 01:16:27 +0000 (UTC) Received: from [192.168.2.51] (85.253.86.235.cable.starman.ee [85.253.86.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: leio) by smtp.gentoo.org (Postfix) with ESMTPSA id 17382335C2C for ; Thu, 15 Feb 2018 01:16:25 +0000 (UTC) Message-ID: <1518657382.7888.1.camel@gentoo.org> Subject: Re: [gentoo-dev] rfc: Remove inherit eutils from font.eclass for EAPI=6 From: Mart Raudsepp To: gentoo-dev@lists.gentoo.org Date: Thu, 15 Feb 2018 03:16:22 +0200 In-Reply-To: <98bd92fe-6583-a9e9-0590-2fe9204ff2ec@gentoo.org> References: <98bd92fe-6583-a9e9-0590-2fe9204ff2ec@gentoo.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: 2bd0eb94-3a78-4fac-b42b-ac72caa65510 X-Archives-Hash: a3da75a29c9a72648feb347cf8afccb0 On Wed, 2018-02-14 at 23:43 +0100, Jonas Stein wrote: > Did I miss something? > Who can help to check with (an automatic) testenvironment, if these > packages will survive? Don't check with test environments, read the ebuilds. Test environments will find it hard to catch changes in the installed files. For example the first issue in that list I found was relying on the inherit for a make_desktop_entry call. In a test environment, it'll just not install a desktop entry while outputting a function not found call or something I suspect. You are lucky if that message is somehow parsed out, and then there are other similar issues possible. (In this example, inheriting desktop.eclass should be added to the ebuild before eclass drops the eutils inherit) If you want to do it, really should just read over all these ebuilds manually. A test environment has a hard time to catch some sort of conditional calls to eutils functions as well, when they don't enter that conditional block for any reason. I suspect most others than this xmind are rather simple ones that don't even have anything beyond declaring the DEPEND and other variables. Also start with the patch to bail out on unknown EAPI's that you were planning to do. This can be separate commit done before this change, once checks are done. Of course ideally pushed together (if the eutils drop pans out) to minimize cache regenerations for developers. Mart