From: Mart Raudsepp <leio@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] rfc: Remove inherit eutils from font.eclass for EAPI=6
Date: Thu, 15 Feb 2018 03:16:22 +0200 [thread overview]
Message-ID: <1518657382.7888.1.camel@gentoo.org> (raw)
In-Reply-To: <98bd92fe-6583-a9e9-0590-2fe9204ff2ec@gentoo.org>
On Wed, 2018-02-14 at 23:43 +0100, Jonas Stein wrote:
> Did I miss something?
> Who can help to check with (an automatic) testenvironment, if these
> packages will survive?
Don't check with test environments, read the ebuilds. Test environments
will find it hard to catch changes in the installed files. For example
the first issue in that list I found was relying on the inherit for a
make_desktop_entry call. In a test environment, it'll just not install
a desktop entry while outputting a function not found call or something
I suspect. You are lucky if that message is somehow parsed out, and
then there are other similar issues possible. (In this example,
inheriting desktop.eclass should be added to the ebuild before eclass
drops the eutils inherit)
If you want to do it, really should just read over all these ebuilds
manually. A test environment has a hard time to catch some sort of
conditional calls to eutils functions as well, when they don't enter
that conditional block for any reason.
I suspect most others than this xmind are rather simple ones that don't
even have anything beyond declaring the DEPEND and other variables.
Also start with the patch to bail out on unknown EAPI's that you were
planning to do. This can be separate commit done before this change,
once checks are done. Of course ideally pushed together (if the eutils
drop pans out) to minimize cache regenerations for developers.
Mart
next prev parent reply other threads:[~2018-02-15 1:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 22:43 [gentoo-dev] rfc: Remove inherit eutils from font.eclass for EAPI=6 Jonas Stein
2018-02-15 1:16 ` Mart Raudsepp [this message]
2018-02-15 7:46 ` Guilherme Amadio
2018-02-15 11:07 ` Jonas Stein
2018-02-15 12:07 ` Mart Raudsepp
2018-05-05 19:52 ` Jonas Stein
2018-02-15 6:42 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518657382.7888.1.camel@gentoo.org \
--to=leio@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox