From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] bzr.eclass: Drop bzr_bootstrap and bzr_src_prepare.
Date: Wed, 07 Feb 2018 14:26:09 +0100 [thread overview]
Message-ID: <1518009969.1228.9.camel@gentoo.org> (raw)
In-Reply-To: <23162.64658.663829.538888@a1i15.kph.uni-mainz.de>
W dniu śro, 07.02.2018 o godzinie 14∶18 +0100, użytkownik Ulrich Mueller
napisał:
> > > > > > On Wed, 07 Feb 2018, Michał Górny wrote:
> > > -# @FUNCTION: bzr_src_prepare
> > > -# @DESCRIPTION:
> > > -# Default src_prepare(), calls bzr_bootstrap.
> > > -bzr_src_prepare() {
> > > - bzr_bootstrap
> > > }
> > Hmm, unless I'm mistaken, this can cause another definition
> > of src_prepare to start applying to ebuilds.
>
> That's right, but wasn't relying on inherit order considered a QA
> violation? In other words, shouldn't an ebuild define an explicit
> phase function if it inherits more than one eclass exporting that
> function?
Not that I know of. However, I was actually more worried about ebuilds
whose authors didn't even notice it.
> > You can submit a PR with this change to get md5-cache with exported
> > phase data suitable for comparison.
> > Or... given the popularity of the eclass, you can check by hand ;-P.
>
> Done so for the Gentoo repo (before posting the patch). Or rather,
> I have checked that WORKDIR has identical contents after the prepare
> phase.
Good enough for me.
--
Best regards,
Michał Górny
prev parent reply other threads:[~2018-02-07 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 13:57 [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command Ulrich Müller
2018-02-06 14:12 ` Kristian Fiskerstrand
2018-02-06 14:36 ` Ulrich Mueller
2018-02-06 14:40 ` eclass committ message verbosity (Was: Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.) Kristian Fiskerstrand
2018-02-06 17:07 ` [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command Alec Warner
2018-02-06 20:07 ` Michał Górny
2018-02-06 23:24 ` [gentoo-dev] [PATCH] bzr.eclass: Drop bzr_bootstrap and bzr_src_prepare Ulrich Müller
2018-02-07 7:34 ` Michał Górny
2018-02-07 13:18 ` Ulrich Mueller
2018-02-07 13:26 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518009969.1228.9.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox