From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: vim@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3] vim-plugin.eclass: use Portage internal variables.
Date: Sun, 05 Nov 2017 00:26:33 +0100 [thread overview]
Message-ID: <1509837993.10754.0.camel@gentoo.org> (raw)
In-Reply-To: <20171104214844.22218-3-monsieurp@gentoo.org>
W dniu sob, 04.11.2017 o godzinie 22∶48 +0100, użytkownik Patrice
Clement napisał:
> Closes: https://bugs.gentoo.org/469400
> ---
> eclass/vim-plugin.eclass | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/eclass/vim-plugin.eclass b/eclass/vim-plugin.eclass
> index a05cdb4520b..3c809768cf8 100644
> --- a/eclass/vim-plugin.eclass
> +++ b/eclass/vim-plugin.eclass
> @@ -39,11 +39,11 @@ vim-plugin_src_install() {
> ebegin "Fixing file permissions"
> # Make sure perms are good
> chmod -R a+rX "${S}" || die "chmod failed"
> - find "${S}" -user 'portage' -exec chown root '{}' \; || die "chown failed"
> + find "${S}" -user "${PORTAGE_USERNAME}" -exec chown root '{}' \; || die "chown failed"
> if use userland_BSD || [[ ${CHOST} == *-darwin* ]] ; then
> - find "${S}" -group 'portage' -exec chgrp wheel '{}' \; || die "chgrp failed"
> + find "${S}" -group "${PORTAGE_GRPNAME}" -exec chgrp wheel '{}' \; || die "chgrp failed"
> else
> - find "${S}" -group 'portage' -exec chgrp root '{}' \; || die "chgrp failed"
> + find "${S}" -group "${PORTAGE_GRPNAME}" -exec chgrp root '{}' \; || die "chgrp failed"
> fi
> eend $?
> fi
This is going to die on every non-Portage package manager.
--
Best regards,
Michał Górny
next prev parent reply other threads:[~2017-11-04 23:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 21:48 [gentoo-dev] [PATCH 0/3] vim-plugin.eclass: improvements Patrice Clement
2017-11-04 21:48 ` [gentoo-dev] [PATCH 1/3] vim-plugin.eclass: dohtml is now obsolete Patrice Clement
2017-11-04 23:09 ` Ulrich Mueller
2017-11-04 21:48 ` [gentoo-dev] [PATCH 2/3] vim-plugin.eclass: use Portage internal variables Patrice Clement
2017-11-04 23:04 ` Ulrich Mueller
2017-11-04 23:26 ` Michał Górny [this message]
2017-11-05 13:53 ` Patrice Clement
2017-11-05 17:24 ` Ulrich Mueller
2017-11-04 21:48 ` [gentoo-dev] [PATCH 3/3] vim-plugin.eclass: rework if else clause and reduce find calls down to one Patrice Clement
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509837993.10754.0.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=vim@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox