From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 49BBE1396D0 for ; Tue, 15 Aug 2017 17:49:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 250F61FC097; Tue, 15 Aug 2017 17:49:40 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C134B1FC002 for ; Tue, 15 Aug 2017 17:49:39 +0000 (UTC) Received: from ham (p4FD3C6FE.dip0.t-ipconnect.de [79.211.198.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tomjbe) by smtp.gentoo.org (Postfix) with ESMTPSA id 379D034179C for ; Tue, 15 Aug 2017 17:49:37 +0000 (UTC) Received: by ham (sSMTP sendmail emulation); Tue, 15 Aug 2017 19:49:33 +0200 From: tomjbe@gentoo.org Content-Type: text/plain; charset="utf-8" Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable User-Agent: alot/0.5.1 To: gentoo-dev@lists.gentoo.org References: <20170814215842.55855987@ham> <1502747720.9741.0.camel@gentoo.org> <150277294168.6272.8309842023603072749@ham.local.de> <1502779387.828.2.camel@gentoo.org> <150278874167.21353.342202167767854341@ham.local.de> In-Reply-To: Message-ID: <150281937316.24489.8886457675831488368@ham.local.de> Subject: Re: [gentoo-dev] [FRC] News item: Changing USE flags for >=app-backup/bacula Date: Tue, 15 Aug 2017 19:49:33 +0200 X-Archives-Salt: 90cfcecf-c8a4-4ee5-a172-aa0d5d18c889 X-Archives-Hash: 34060741bfe6fe853054b414e522ac73 Quoting Rich Freeman (2017-08-15 14:16:14) > On Tue, Aug 15, 2017 at 5:19 AM, wrote: > > Quoting Micha=C5=82 G=C3=B3rny (2017-08-15 08:43:07) > >> On wto, 2017-08-15 at 06:55 +0200, tomjbe@gentoo.org wrote: > >> > Quoting Rich Freeman (2017-08-15 00:29:19) > >> > > > >> > > I guess to make it a bit more explicit, would it make sense to hav= e 3 flags: > >> > > > >> > > client - install the client (or consider calling it file-daemon = instead) > >> > > director - install the director > >> > > storage-daemon - install the storage daemon > >> > > > >> > > >> > That would be best, but it is not supported by their (autoconf based= ) build > >> > system (and would require a complete rewrite of it). The actual USE = flags > >> > mostly mirrors the switches from the configure script. You can not s= et them as > >> > you like, they are not orthogonal E.g. the file deamon (client) will= be > >> > installed unconditionally. > >> > > >> > The configure script itself is very brittle atm and needs an urgent = overhaul. > >> > Discussion with upstream goes a long way, but they do not want to ch= ange it > >> > because of the need to retest it on very different systems. No good = situation. > >> > > >> > A possible idea may be to drop the 'no/client' flag completely. If n= either > >> > 'director' nor 'storage-daemon' is active all that is left would be = the > >> > file daemon. > >> > What do you think? > >> > >> WFM. If the flag doesn't do anything except for disabling the two other > >> flags, then there's no place for such a flag. > >> > > And here comes the problem. USE=3D"bacula-nodir bacula-nosd" does not p= roduce > > the same set of files as USE=3D"bacula-clientonly". But I will recheck = if the > > difference is of relevance for normal gentoo user. > = > It is probably worth understanding the difference. However, if the > user sets both -director and -storage-daemon you could also enable > bacula-clientonly, unless there is some reason somebody might want two > of those and not the third. > = I just tested the different use flags settings as well as directly the different configure switches. Here is what happens for configure: * Deactivation of storage-daemon drops the related files. * Deactivation of director ist ignored by the build system, the director is build anyway (One more bug in their build system). * Activation of clientonly drops both the related files for director and for storage daemon. The ebuild does fix some of the differences: * +bacula-nodir and +bacula+nosd drops most of the files for these functionality, but keeps some more (mostly irrelevant) files over +bacula-clientonly. So from gentoos point of view having nodir and nosd is nearly the same as having clientonly. That would allow to drop the clientonly flag and keep on= ly the controling flags for director and storage-daemon. > > > >> > > >> > The downside of that idea is that we diverge from baculas documentat= ion which > >> > explicitly state that there is a 'clientonly' install. > >> > > >> > >> Upstream install documentation is not relevant to Gentoo. The flag > >> descriptions in metadata.xml are. > >> > > Right. But if we drop a "clientonly" than there is no hint in metadata.= xml how > > to get only the file daemon alone. Some einfo output or similar come to= mind. > > > = > You could use einfo. However, if the docs say what the other two > flags do then it seems pretty obvious that if you turn them both off > you end up with only the file daemon. > = I think we can find a proper formulation for the use flag description in metadata.xml, e.g.: director - Installs the backup director additional to the default file daem= on. storage-daemon - Installs the storage daemon additional to the default file daemon. Thomas