public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [FRC] News item: Changing USE flags for >=app-backup/bacula
Date: Tue, 15 Aug 2017 08:43:07 +0200	[thread overview]
Message-ID: <1502779387.828.2.camel@gentoo.org> (raw)
In-Reply-To: <150277294168.6272.8309842023603072749@ham.local.de>

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

On wto, 2017-08-15 at 06:55 +0200, tomjbe@gentoo.org wrote:
> Quoting Rich Freeman (2017-08-15 00:29:19)
> > On Mon, Aug 14, 2017 at 5:55 PM, Michał Górny <mgorny@gentoo.org> wrote:
> > > On pon, 2017-08-14 at 21:58 +0200, Thomas Beierlein wrote:
> > > > 
> > > > * 'bacula-clientonly' becomes 'clientonly'
> > > 
> > > This is still negative logic in disguise. clientonly = noserver.
> 
> True. See below for discussion.
> > > 
> > > > * 'bacula-nodir' will be replaced by 'director' but with inverted logic
> > > > * 'bacula-nosd' will be replaced by 'storage-daemon' (also inverted).
> > > > 
> > > > 'director' and 'storage-daemon' will be active by default resulting in an
> > > > installation with backup director and storage daemon enabled.
> > > > 
> > 
> > ++
> > 
> > I guess to make it a bit more explicit, would it make sense to have 3 flags:
> > 
> > client - install the client   (or consider calling it file-daemon instead)
> > director - install the director
> > storage-daemon - install the storage daemon
> > 
> 
> That would be best, but it is not supported by their (autoconf based) build
> system (and would require a complete rewrite of it). The actual USE flags
> mostly mirrors the switches from the configure script. You can not set them as
> you like, they are not orthogonal E.g. the file deamon (client) will be
> installed unconditionally.
> 
> The configure script itself is very brittle atm and needs an urgent overhaul.
> Discussion with upstream goes a long way, but they do not want to change it
> because of the need to retest it on very different systems. No good situation.
> 
> A possible idea may be to drop the 'no/client' flag completely. If neither
> 'director' nor 'storage-daemon' is active all that is left would be the 
> file daemon.
> What do you think?

WFM. If the flag doesn't do anything except for disabling the two other
flags, then there's no place for such a flag.

> 
> The downside of that idea is that we diverge from baculas documentation which
> explicitly state that there is a 'clientonly' install. 
> 

Upstream install documentation is not relevant to Gentoo. The flag
descriptions in metadata.xml are.

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 988 bytes --]

  reply	other threads:[~2017-08-15  6:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 19:58 [gentoo-dev] [FRC] News item: Changing USE flags for >=app-backup/bacula Thomas Beierlein
2017-08-14 21:55 ` Michał Górny
2017-08-14 22:29   ` Rich Freeman
2017-08-15  4:55     ` tomjbe
2017-08-15  6:43       ` Michał Górny [this message]
2017-08-15  9:19         ` tomjbe
2017-08-15 12:16           ` Rich Freeman
2017-08-15 17:49             ` tomjbe
2017-08-16  1:32               ` M. J. Everitt
2017-08-16  1:45               ` [gentoo-dev] " Duncan
2017-08-16  6:04                 ` tomjbe
2017-08-15  8:37     ` [gentoo-dev] " Kristian Fiskerstrand
2017-08-15  9:33       ` tomjbe
2017-08-15  9:45         ` Kristian Fiskerstrand
2017-08-15 12:21           ` Rich Freeman
2017-08-15 13:25             ` Kristian Fiskerstrand
2017-08-15 14:02               ` Rich Freeman
2017-08-16 12:36 ` tomjbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502779387.828.2.camel@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox