From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 898951396D0 for ; Thu, 10 Aug 2017 07:40:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E76811FC040; Thu, 10 Aug 2017 07:40:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 891741FC007 for ; Thu, 10 Aug 2017 07:40:41 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id E609134178A; Thu, 10 Aug 2017 07:40:39 +0000 (UTC) Message-ID: <1502350830.1554.1.camel@gentoo.org> Subject: Re: [gentoo-dev] New package neomutt From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Thu, 10 Aug 2017 09:40:30 +0200 In-Reply-To: <20170810045857.e6qrvnimteopxgev@rubberducky.suse.de> References: <20170731071119.jccco5q4kd3fs4xs@rubberducky.suse.de> <20170810045857.e6qrvnimteopxgev@rubberducky.suse.de> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-qyyQFIswMEKmZlp6I23o" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: afffe748-4e03-40d7-a9a3-2abe6d432279 X-Archives-Hash: 015bb27eccec1da192bf550f18923693 --=-qyyQFIswMEKmZlp6I23o Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On czw, 2017-08-10 at 06:58 +0200, Nicolas Bock wrote: > On Mon, Jul 31, 2017 at 09:11:19AM +0200, Nicolas Bock wrote: > > Hi, > >=20 > > I would like to add neomutt to the tree. This new package is meant as= =20 > > an alternative and not a replacement of the existing mutt package. >=20 > Thanks for all of the great suggestions and feedback! >=20 > This is round two. I have update the ebuild with all your=20 > suggestions. I have also added support for eselecting between mutt=20 > and neomutt. Before the eselect ebuild can land though, we need to=20 > rename the mutt binary so that the managed link can be called=20 > mutt. What for? How many people are exactly in the dire need of having both installed simultaneously and switching between them? If you really can't learn to type the new command, add IUSE=3Dsymlink blocking original mutt and be done with it. Don't add more unowned files to /usr by another poorly written eselect module. > # Copyright 1999-2017 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 >=20 > EAPI=3D6 >=20 > inherit autotools eutils flag-o-matic >=20 > if [[ ${PV} =3D=3D 99999999 ]] ; then > # live ebuild > inherit git-r3 > EGIT_REPO_URI=3D"https://github.com/neomutt/neomutt.git" > EGIT_CHECKOUT_DIR=3D"${WORKDIR}/neomutt-${P}" > KEYWORDS=3D"" This is going to confuse the hell out of ekeyword. > else > SRC_URI=3D"https://github.com/${PN}/${PN}/archive/${P}.tar.gz" > KEYWORDS=3D"~amd64 ~x86" > fi >=20 > DESCRIPTION=3D"Teaching an Old Dog New Tricks" This doesn't tell anybody who doesn't know mutt what this is. > HOMEPAGE=3D"https://www.neomutt.org/" >=20 > LICENSE=3D"GPL-2" > SLOT=3D"0" > IUSE=3D"berkdb crypt debug doc gdbm gnutls gpg idn kerberos libressl mbox > nls notmuch qdbm sasl selinux slang smime ssl tokyocabinet kyotocabinet > lmdb" Sort lexically. >=20 > CDEPEND=3D" > app-eselect/eselect-mutt > app-misc/mime-types > nls? ( virtual/libintl ) > tokyocabinet? ( dev-db/tokyocabinet ) > qdbm? ( dev-db/qdbm ) > gdbm? ( sys-libs/gdbm ) > berkdb? ( >=3Dsys-libs/db-4:=3D ) > kyotocabinet? ( dev-db/kyotocabinet ) > lmdb? ( dev-db/lmdb ) > gnutls? ( >=3Dnet-libs/gnutls-1.0.17 ) > !gnutls? ( > ssl? ( > !libressl? ( >=3Ddev-libs/openssl-0.9.6:0 ) > libressl? ( dev-libs/libressl ) > ) > ) This is not a correct use of 'ssl' flag: =C2=A0global:ssl: Add support for Secure Socket Layer connections It's supposed to go top-level, above any implementation flags. > sasl? ( >=3Ddev-libs/cyrus-sasl-2 ) > kerberos? ( virtual/krb5 ) > idn? ( net-dns/libidn ) > gpg? ( >=3Dapp-crypt/gpgme-0.9.0 )=09 > smime? ( > !libressl? ( >=3Ddev-libs/openssl-0.9.6:0 ) > libressl? ( dev-libs/libressl ) What is the point of preferring gnutls when USE=3Dsmime pulls openssl anyway? > ) > notmuch? ( net-mail/notmuch ) > slang? ( sys-libs/slang ) > !slang? ( >=3Dsys-libs/ncurses-5.2:0 ) Why not =3D slotop? ncurses definitely changed ABI in the past. It's something you are supposed to use when needed, not when repoman complains about it and you didn't accidentally workaround the check. Sorting this would also help reviews. > " > DEPEND=3D"${CDEPEND} > net-mail/mailbase > doc? ( > dev-libs/libxml2 > dev-libs/libxslt > app-text/docbook-xsl-stylesheets > || ( www-client/lynx www-client/w3m www-client/elinks ) > )" > RDEPEND=3D"${CDEPEND} > selinux? ( sec-policy/selinux-mutt ) > " >=20 > S=3D"${WORKDIR}/${PN}-${P}" >=20 > src_prepare() { > eapply "${FILESDIR}/0001-Rename-mutt-to-neomutt.patch" > eapply_user > AT_M4DIR=3D"m4" eautoreconf > } >=20 > src_configure() { > local myconf=3D( > "$(use_enable crypt pgp)" > "$(use_enable debug)" > "$(use_enable doc)" > "$(use_enable gpg gpgme)" > "$(use_enable nls)" > "$(use_enable smime)" > "$(use_enable notmuch)" > "$(use_with idn)" > "$(use_with kerberos gss)" > "$(use_with sasl)" > "$(use_with tokyocabinet)" > "$(use_with kyotocabinet)" > "$(use_with qdbm)" > "$(use_with gdbm)" > "$(use_with berkdb bdb)" > "$(use_with lmdb)" > "--with-$(use slang && echo slang || echo curses)=3D${EPREFIX}/usr" usex > "--sysconfdir=3D${EPREFIX}/etc/${PN}" I'd really prefer if you didn't abuse PN to construct paths, and make me wonder if upstream really wants 'neomutt' or 'mutt' here. > "--with-docdir=3D${EPREFIX}/usr/share/doc/${PN}-${PVR}" PF? > ) >=20 > if [[ ${CHOST} =3D=3D *-solaris* ]] ; then > # arrows in index view do not show when using wchar_t > myconf+=3D( "--without-wc-funcs" ) > fi Are you sure that this still applies? >=20 > # there's no need for gnutls, ssl or sasl without socket support What is this comment supposed to mean? Looks like copy-paste without even reading it. > if use gnutls; then > myconf+=3D( "--with-gnutls" ) > elif use ssl; then > myconf+=3D( "--with-ssl" ) > fi >=20 > if use mbox; then > myconf+=3D( "--with-mailpath=3D${EPREFIX}/var/spool/mail" ) > else > myconf+=3D( "--with-homespool=3DMaildir" ) > fi Would configuring both paths do any harm? Maybe it'd make easier for user to switch without having to rebuild it. >=20 > econf "${myconf[@]}" > } >=20 > src_install() { > emake DESTDIR=3D"${D}" install > if use mbox; then > insinto /etc/${PN} You can move the insinto above the 'if'. > newins "${FILESDIR}"/Muttrc.mbox Muttrc > else > insinto /etc/${PN} > doins "${FILESDIR}"/Muttrc > fi >=20 > # A newer file is provided by app-misc/mime-types. So we link it. > rm "${ED}"/etc/${PN}/mime.types || die > dosym /etc/mime.types /etc/${PN}/mime.types Don't use absolute symlinks. >=20 > # A man-page is always handy, so fake one > if use !doc; then > emake -C doc DESTDIR=3D"${D}" muttrc.man Is DESTDIR really necessary here? > # make the fake slightly better, bug #413405 > sed -e 's#@docdir@/manual.txt#http://www.mutt.org/doc/manual/#' \ > -e 's#in @docdir@,#at http://www.mutt.org/,#' \ You sure you want to link to the original mutt.org? > -e "s#@sysconfdir@#${EPREFIX}/etc/${PN}#" \ > -e "s#@bindir@#${EPREFIX}/usr/bin#" \ > doc/mutt.man > neomutt.1 || die > cp doc/muttrc.man neomuttrc.5 || die > doman neomutt.1 neomuttrc.5 > else > # nuke manpages that should be provided by an MTA, bug #177605 > rm "${ED}"/usr/share/man/man5/{mbox,mmdf}.5 \ > || ewarn "failed to remove files, please file a bug" die. > fi >=20 > dodoc COPYRIGHT ChangeLog* OPS* README* > } >=20 --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-qyyQFIswMEKmZlp6I23o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKmBAABCgCQFiEEbbsHzE8NrQbqCv5BsHoa6u+0Rk4FAlmMDe5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDZE QkIwN0NDNEYwREFEMDZFQTBBRkU0MUIwN0ExQUVBRUZCNDQ2NEUSHG1nb3JueUBn ZW50b28ub3JnAAoJELB6GurvtEZOl7MQAIU1KeDWDyv31NuYULZXhGKLcqH6jFPz jNz7jS/QHaqIvpzZu/B6F/fNFIeG64nQXTMGgiDIvyUZPw2NN67C5i0hmsihA+7k oYq98NhW4fKNTOegVfN+Mrjqlmin7dlXAkOXHXgPcumEefDmGsb/QTuvJ1Hc6d47 oGswSyrr7B39X9/l0ojRZFiilJRQV199WByo0NI9Ei1kw0RnXafo1QZCV/NWio/g eUKbv2zR9QaYH6m1u1PESvOcxoGiVBOfGslPa98yijLv6Nml/2dW5PBQLv3DK9Zb ORJPHZjRR14ARAxsILV4x1QiU0mGo/1ubbBMkdQd/rCMRuPor/RZf9BhAkUqq0Zj 5frQP5mGR296mtwQzwkoMG/CPAN+tPYd3j7ql14fvOVAwMNduN8jhPLrYH7sWQbC VE9OSVotO7w+KqxU9AXFvsKE7YGMYAs9z4WiIsfezxtnjTxOMTK3mmeP8LV6XB2N PRNyPnkJePw1wZDTSd05331cFHw73VmGGfGQKWtpGKFEqgTy77WRqH/I9M84L7Ve 5j5JX3KkkQ//esyE6QJA3v9umUdsl0to7LWOa/krWXLAn9sbqbNUSzSI+JL92Rdd bS0fqYXKYdy07ZiUpZW4SXYpMpjGCVAyoJNSLpA/J1nRfXVtyO/Rbys5dP1RCCDr 9lzD8yy2kl18 =f7+H -----END PGP SIGNATURE----- --=-qyyQFIswMEKmZlp6I23o--