From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4CAB1139694 for ; Fri, 4 Aug 2017 06:50:45 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E886BE0E93; Fri, 4 Aug 2017 06:50:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8B464E0E82 for ; Fri, 4 Aug 2017 06:50:37 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 9CE21341912; Fri, 4 Aug 2017 06:50:35 +0000 (UTC) Message-ID: <1501829424.2012.3.camel@gentoo.org> Subject: Re: [gentoo-dev] Allow variable refs in HOMEPAGE From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Fri, 04 Aug 2017 08:50:24 +0200 In-Reply-To: References: <3585822f-4db2-8c46-b037-cb84cb5bed6d@gentoo.org> <1991270a-482d-28f0-4834-8308b4c27351@gentoo.org> <7d77f767-5fd9-e0f0-732e-c1de9e2bf182@gentoo.org> <22915.42159.105748.809987@a1i15.kph.uni-mainz.de> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-33z52UrsvmLyVb/92pNP" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: cee66ef7-cc69-4d6d-a9df-18f6c72b62c5 X-Archives-Hash: 8c9747e7c54ac2210e09b08e9fb14651 --=-33z52UrsvmLyVb/92pNP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On czw, 2017-08-03 at 23:24 -0400, Michael Orlitzky wrote: > On 08/03/2017 06:33 PM, Ulrich Mueller wrote: > > > > > > > On Thu, 3 Aug 2017, Michael Orlitzky wrote: > > > The developer handbook that I just said didn't mention variables in > > > HOMEPAGE at all. > >=20 > > It did, even back in 2004: > > https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/xml/htdocs/proj/en= /devrel/handbook/hb-guide-ebuild.xml?hideattic=3D0&revision=3D1.10&view=3Dm= arkup#l534 > >=20 >=20 > You got me, but now we can see where that text came from and it proves > my original point that the last line was added as an afterthought and > isn't any sort of policy: >=20 > https://bugs.gentoo.org/show_bug.cgi?id=3D73272 >=20 > Which is good, because it's a silly rule, and hundreds of ebuilds in the > tree wisely ignore it. There's a significant difference between being unaware of a policy and intentionally disrespecting it. Now that you've been made aware, we can start pursuing it. > Why single out HOMEPAGE? I might like to copy/paste the econf arguments, > so should we forbid the use of $(use_enable foo) and force everyone to > use "if" statements? Of course not; if you need the value of HOMEPAGE > (or anything else), there are more intelligent ways to get it than > opening up the ebuild, digging though the source code, and manually > performing the variable substitutions that the programming language is > there to do for us. >=20 > Use the metadata, use eix, use emerge --search, write an echo statement > into the ebuild, whatever. Don't handicap everyone so that you can treat > their source code as part of your user interface. Why is it fine for you to handicap everyone else for your personal laziness? As it's been told more than once, you write ebuild *once*, people read it *multiple times*. When reviewing pull requests, submitted ebuilds etc. I *have to* verify this stuff. I don't have time to copy everything to a local tree just to get some random tool process it correctly and give me the value I need. Just to figure out there's some trivial issue that blocks any further progress, and I will have to do this again, and again, and again. Because someone thinks it's cool to save 5 bytes in variable references. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-33z52UrsvmLyVb/92pNP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKmBAABCgCQFiEEbbsHzE8NrQbqCv5BsHoa6u+0Rk4FAlmEGTBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDZE QkIwN0NDNEYwREFEMDZFQTBBRkU0MUIwN0ExQUVBRUZCNDQ2NEUSHG1nb3JueUBn ZW50b28ub3JnAAoJELB6GurvtEZOE5gQAImqRJrohZxIaMwGAC7ajOFnHAi8CuJX 3G7wVi9NQRe/f4tJeMEzWN5qIGlvEonAgatPPXZKGMY14E4FSjQMZN9b/Qzh4zZn 8S+P96gfB71knCTLZFS6gibmXHT0r2ESmAugs9fImtXkF4A3gh7JXj4K4REg6YH0 C/DgAN0r+bCEnhY2/3IDB1ryqTkXTz14E8Guhc0OUkAxG7wyIIn5S2XK2SIULbsF EZCBmvHn0+nCi6rnykwMqkEwOCv7d7CmESRcGDXcN4O+Vqj/WuWQtyaPT+GrtbfF gfybBo2UDHr1ugR4rU/DEBsHVO40MWEo1v1X3OFKgheGJPDs3Ekkr6aEDg8V3Esu nkFYEUYVxmVxrfE7tTlqaF2dSBKp+sFKQo7AmAqM9EFqQiPEQmTxX0AGGQSn6xZd +C4qvU2RFWMSELR7G7o05D1SlYCDEMFltm6u/HcGoC4un5/PKdQ7oT8iT3uNtfTG kb27Xj4Z1KTE65o4j2g3wZmayMXbj7KoLSh6ds3646fdThs2sRfOsGMCPr+JNhLQ 45XvvvA/4Mjc14oIjAtPLYa30Pm2Vhh7K9zGoMo32G3+wTDxm+7upeSYo0572CHg 2/XcRrzEBTBeShQ08ncvs0BCQ4hOIHta3mzQwGvbJmInDikDwBg1AU5ZO6Xp6xe6 Xaymth7tkLzU =8NS5 -----END PGP SIGNATURE----- --=-33z52UrsvmLyVb/92pNP--