From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 88C7B139694 for ; Tue, 25 Jul 2017 13:37:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0DDE81FC08D; Tue, 25 Jul 2017 13:37:22 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BA28C1FC06D for ; Tue, 25 Jul 2017 13:37:11 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 2CA283417D0; Tue, 25 Jul 2017 13:37:10 +0000 (UTC) Message-ID: <1500989826.795.8.camel@gentoo.org> Subject: Re: [gentoo-dev] New eclass: opam.eclass From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Tue, 25 Jul 2017 15:37:06 +0200 In-Reply-To: <20170725124833.GX12397@stuge.se> References: <20170724172032.0a6623dc@gentoo.org> <20170724221139.GC15937@gengoff> <20170725102558.79b2cbaa@gentoo.org> <20170725124833.GX12397@stuge.se> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-/wdHiQXha47Xn2h7rw1d" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 11d2189d-05a4-4227-9cf7-5025496580d1 X-Archives-Hash: af8b3c8d8d5b3c9ae980deac0929f5e2 --=-/wdHiQXha47Xn2h7rw1d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On wto, 2017-07-25 at 12:48 +0000, Peter Stuge wrote: > Good work on the refactoring! >=20 > Alexis Ballier wrote: > > > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then =20 > > >=20 > > > It=E2=80=99s always been recommended to me that we should use the [[ = =E2=80=A6 ]] > > > form. > >=20 > > Doesn't make much difference here >=20 > Some; you need neither quote nor {} in expansions within [[ ]]. So > instead of the above one could write: {} is completely irrelevant to [ ] vs [[ ]]. >=20 > if [[ -d $ED/usr/share/doc/$PF/$PN ]]; then >=20 >=20 > > and I've always been recommending the other way :p >=20 > .. > > if you only do ebuilds or bash, then you don't care, but I definitely > > do other scripts >=20 > Be that as it may this is an eclass, and I think conforming to an > established coding style has significant value. I too have understood > that to be [[ ]]. ...and ${}. >=20 >=20 > Thanks >=20 > //Peter >=20 --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-/wdHiQXha47Xn2h7rw1d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKmBAABCgCQFiEEbbsHzE8NrQbqCv5BsHoa6u+0Rk4FAll3SYNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDZE QkIwN0NDNEYwREFEMDZFQTBBRkU0MUIwN0ExQUVBRUZCNDQ2NEUSHG1nb3JueUBn ZW50b28ub3JnAAoJELB6GurvtEZOgkAP/29vLPkHUYeooGK2A/VlbkNYfseSCiX5 uy2+6crTg0Fu/pOMPkFImQhsfJaERQ8Sp7BDEsNx3uh99yxZhFj56wY8LmT+xYRl FjOS5CMlzO/kGpz8mD6Oq+PesY3PefaRIPfspTC8itLathV/08uvT+nkb1zJ68Pi AA8Gq2TjXNpqIMvqEFekKbrkiIgSM4B57KH7bRWq1TPF+MRZYXamWdzh9P0lDRfj +vj9qYskyuM/twnztjb7H3yOxXsLpOaZeFZEX9lNvLTeyMnlbluGwuwrSXUmZgzp 1XWDblDkPs1FPDcqX7eMb2VAD3oJbwmdVEEV70SMz8h/voEPT9T3EQsSGtWk522m m2/Q2ek3hYonBTTEnJw4XM14FDJTssIYLse79HytQpe2AjVVA+Sv9U7ageswt8Ns /GrXHSeTxM6/0p9Ibnsjxe5KXROyEpj4+JPm72EUuGI5S3Dd5ewoYD+LNuGSb05x tpOZVWnAE7GAHLvU+1AUwGMFt4o/o4l8+wzfusf9AXZceZyrOMv0nZktkuEvvIfS qg4tinST7EN4hAKMuMS4JKSTzeFJOO8qaYLmFU+0ajnzps8I03F6s1QMoLyiKU2P WOR4flUjc8gRyuoSc7Gj454UoDaJqhnesg/0/tfw8xA2Oec2nN7gtFX+bQFThRQJ KyIC9ezk7i9W =4sbn -----END PGP SIGNATURE----- --=-/wdHiQXha47Xn2h7rw1d--