From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8B5E9139694 for ; Wed, 14 Jun 2017 07:42:29 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5C89621C08F; Wed, 14 Jun 2017 07:42:22 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id F334821C07E for ; Wed, 14 Jun 2017 07:42:21 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id C8BCA341A3A; Wed, 14 Jun 2017 07:42:19 +0000 (UTC) Message-ID: <1497426126.1187.0.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] systemd.eclass: Improve systemd_install_serviced documentation From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Wed, 14 Jun 2017 09:42:06 +0200 In-Reply-To: References: <20170611192351.5138-1-aklhfex@gmail.com> <1497394718.10343.1.camel@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-nzl+k7gi7CpQCPV3bOfh" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 91b2c343-a86b-4d13-8fa0-a283ba646f6e X-Archives-Hash: c8f5b20170ba80378713387f50dd3211 --=-nzl+k7gi7CpQCPV3bOfh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On wto, 2017-06-13 at 22:52 -0400, Mike Gilbert wrote: > On Tue, Jun 13, 2017 at 6:58 PM, Micha=C5=82 G=C3=B3rny wrote: > > On nie, 2017-06-11 at 20:23 +0100, Chris Mayo wrote: > > > Signed-off-by: Chris Mayo > > > --- > > >=20 > > > Nothing added, just suggesting how it could be made easier to underst= and. > > >=20 > > > Chris > > >=20 > > > eclass/systemd.eclass | 10 +++++----- > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > >=20 > > > diff --git a/eclass/systemd.eclass b/eclass/systemd.eclass > > > index 7e46e80119c..49f7480228b 100644 > > > --- a/eclass/systemd.eclass > > > +++ b/eclass/systemd.eclass > > > @@ -178,12 +178,12 @@ systemd_newuserunit() { > > > } > > >=20 > > > # @FUNCTION: systemd_install_serviced > > > -# @USAGE: [] > > > +# @USAGE: [] > > > # @DESCRIPTION: > > > -# Install the file as service.d/00gentoo.conf template. > > > -# The argument specifies the configured service name. > > > -# If not specified, the configuration file name will be used with .c= onf > > > -# suffix stripped (e.g. foo.service.conf -> foo.service). > > > +# Install as the template .d/00gentoo.conf. > > > +# If is not specified > > > +# with the .conf suffix stripped is used > > > +# (e.g. foo.service.conf -> foo.service.d/00gentoo.conf). > > > systemd_install_serviced() { > > > debug-print-function ${FUNCNAME} "${@}" > > >=20 > >=20 > > This is meritoriously wrong. The second argument is required to have > > '.d' suffix, while your help text suggests that '.d' is appended > > implicitly. >=20 > WTF are you talking about? >=20 > # avoid potentially common mistake > [[ ${service} =3D=3D *.d ]] && die "Service must not have .d suffix" >=20 A thinko then. Nevermind. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-nzl+k7gi7CpQCPV3bOfh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKmBAABCgCQFiEEbbsHzE8NrQbqCv5BsHoa6u+0Rk4FAllA6M9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDZE QkIwN0NDNEYwREFEMDZFQTBBRkU0MUIwN0ExQUVBRUZCNDQ2NEUSHG1nb3JueUBn ZW50b28ub3JnAAoJELB6GurvtEZO/F4P/2YPD4K3nOlXIWQtiZHpNiGC4tRDpMbe yXjvaBNzpO59A9t9vK7kYdksx5pJL6Bv0vz/DzHCvlJ5loPqstsMhRHaV6DYgbr7 G9rs9oxdQPfYmcwrCGfZgss5bvjcXq19Q6++mMCs5JSNQfWCWWakVW28VYdvZ9ah hxcG0BcRLkbq3SDQM9B7MjiQ8gr6urfkYlZTY60g7eP7Jch5GS4JnrA5e7FUigCl KT23In6naHWAy7QlzUwWeRbSweqeHiztEVk+fQYVr9ta0XyNgAR3bUtslHmpTugG IULScXPkMhykAF9a8TKBYPpZuGQ0FW0kcouw4mpUtVub1lolVROr4OizF5dJH6pX 7xHwqHhn0CT8nZZSp9V5vO0QNpCeFN/ZqM9YWr1xXBU/poKwHpHvBEI1neBfNI8c jKynIHAtXm2mdy1o8j7w7w8SboQK5idKlz6dKZXWDZV/OvwIISPwfFarlbAJ052+ VN0RNz0CmV6Gxy8lT5vgwf0p0OLpe8E3sGw09EhXR6juwS59L7PN6gRfL+Nj2Ycx 6nsroY54DFsxeB7BF62GgqBQOLn+lX8KrqVODwVvhaBF0bGsAfDUBLQIQnF1rkQx gk1eTd/O6QlyWrGvUb6hjqqNynSR7IYEyFEKlgrL2Bx1oo35oBHSnl8SijcGXqAu Vcogr6N3Ngnj =e4or -----END PGP SIGNATURE----- --=-nzl+k7gi7CpQCPV3bOfh--