From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] systemd.eclass: Improve systemd_install_serviced documentation
Date: Wed, 14 Jun 2017 09:42:06 +0200 [thread overview]
Message-ID: <1497426126.1187.0.camel@gentoo.org> (raw)
In-Reply-To: <CAJ0EP433gJ8vWA2baJy7Si++WJ=ckWzP9SjNnxyPtkVFTVTcoA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1915 bytes --]
On wto, 2017-06-13 at 22:52 -0400, Mike Gilbert wrote:
> On Tue, Jun 13, 2017 at 6:58 PM, Michał Górny <mgorny@gentoo.org> wrote:
> > On nie, 2017-06-11 at 20:23 +0100, Chris Mayo wrote:
> > > Signed-off-by: Chris Mayo <aklhfex@gmail.com>
> > > ---
> > >
> > > Nothing added, just suggesting how it could be made easier to understand.
> > >
> > > Chris
> > >
> > > eclass/systemd.eclass | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/eclass/systemd.eclass b/eclass/systemd.eclass
> > > index 7e46e80119c..49f7480228b 100644
> > > --- a/eclass/systemd.eclass
> > > +++ b/eclass/systemd.eclass
> > > @@ -178,12 +178,12 @@ systemd_newuserunit() {
> > > }
> > >
> > > # @FUNCTION: systemd_install_serviced
> > > -# @USAGE: <conf-file> [<service.d>]
> > > +# @USAGE: <conf-file> [<service>]
> > > # @DESCRIPTION:
> > > -# Install the file <conf-file> as service.d/00gentoo.conf template.
> > > -# The <service.d> argument specifies the configured service name.
> > > -# If not specified, the configuration file name will be used with .conf
> > > -# suffix stripped (e.g. foo.service.conf -> foo.service).
> > > +# Install <conf-file> as the template <service>.d/00gentoo.conf.
> > > +# If <service> is not specified
> > > +# <conf-file> with the .conf suffix stripped is used
> > > +# (e.g. foo.service.conf -> foo.service.d/00gentoo.conf).
> > > systemd_install_serviced() {
> > > debug-print-function ${FUNCNAME} "${@}"
> > >
> >
> > This is meritoriously wrong. The second argument is required to have
> > '.d' suffix, while your help text suggests that '.d' is appended
> > implicitly.
>
> WTF are you talking about?
>
> # avoid potentially common mistake
> [[ ${service} == *.d ]] && die "Service must not have .d suffix"
>
A thinko then. Nevermind.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 988 bytes --]
prev parent reply other threads:[~2017-06-14 7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-11 19:23 [gentoo-dev] [PATCH] systemd.eclass: Improve systemd_install_serviced documentation Chris Mayo
2017-06-11 22:13 ` Mike Gilbert
2017-06-13 22:58 ` Michał Górny
2017-06-14 2:52 ` Mike Gilbert
2017-06-14 7:42 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497426126.1187.0.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox