From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F37D6139694 for ; Tue, 13 Jun 2017 22:58:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2E81921C07D; Tue, 13 Jun 2017 22:58:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D51B7E0BFA for ; Tue, 13 Jun 2017 22:58:43 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 303EA341788; Tue, 13 Jun 2017 22:58:42 +0000 (UTC) Message-ID: <1497394718.10343.1.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] systemd.eclass: Improve systemd_install_serviced documentation From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Wed, 14 Jun 2017 00:58:38 +0200 In-Reply-To: <20170611192351.5138-1-aklhfex@gmail.com> References: <20170611192351.5138-1-aklhfex@gmail.com> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ak+5xuqbdQ7xOTO4fu47" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 78410532-cfb0-4fcf-b4dd-aacf42429789 X-Archives-Hash: b7829f59fc097e99411c7d0abc402940 --=-ak+5xuqbdQ7xOTO4fu47 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On nie, 2017-06-11 at 20:23 +0100, Chris Mayo wrote: > Signed-off-by: Chris Mayo > --- >=20 > Nothing added, just suggesting how it could be made easier to understand. >=20 > Chris >=20 > eclass/systemd.eclass | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/eclass/systemd.eclass b/eclass/systemd.eclass > index 7e46e80119c..49f7480228b 100644 > --- a/eclass/systemd.eclass > +++ b/eclass/systemd.eclass > @@ -178,12 +178,12 @@ systemd_newuserunit() { > } > =20 > # @FUNCTION: systemd_install_serviced > -# @USAGE: [] > +# @USAGE: [] > # @DESCRIPTION: > -# Install the file as service.d/00gentoo.conf template. > -# The argument specifies the configured service name. > -# If not specified, the configuration file name will be used with .conf > -# suffix stripped (e.g. foo.service.conf -> foo.service). > +# Install as the template .d/00gentoo.conf. > +# If is not specified > +# with the .conf suffix stripped is used > +# (e.g. foo.service.conf -> foo.service.d/00gentoo.conf). > systemd_install_serviced() { > debug-print-function ${FUNCNAME} "${@}" > =20 This is meritoriously wrong. The second argument is required to have '.d' suffix, while your help text suggests that '.d' is appended implicitly. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-ak+5xuqbdQ7xOTO4fu47 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKmBAABCgCQFiEEbbsHzE8NrQbqCv5BsHoa6u+0Rk4FAllAbh5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDZE QkIwN0NDNEYwREFEMDZFQTBBRkU0MUIwN0ExQUVBRUZCNDQ2NEUSHG1nb3JueUBn ZW50b28ub3JnAAoJELB6GurvtEZOwmYP/jlHIQc0AZkDr845ddSsWKaLds/P+UFh ONn7YaYyzF9WGCAjWSnFEAV09GDFjsVEu1JlmRaHoTvDXHEm1kYFMykS/+yJrNm+ fwlZs02TKku2QgUE2Eic2zNAl1ppC3721r5p3pNRa+LLkbmWLzPkgr8CDpv6EaWt 7atDUmKSaHL/9Lgj64HyZpzrmN83tausEYP/VCzSyvMifzWmb8w0aw84c96olyKi PRZ0TFRCv6APTDa6osmK/FAIMdy0O821da+eU/77FyBLEyjkEtDh2L/8Y3oI4aGg iApnnF5yJ2GHpylH6zgxL8ciOHkuy/1qnzXIFd7iszzRkSPaf4Bs0zwnuHSrhP0l HgCBFeUKj4Tz2sMu6rFTTWgs5qHP3g6AJERq0OPn6HFqDJ+3aalZJvilYMzDD2iG k8FC4PUVxiu3upYN7rAM3tufIic1NnyI4Rd+TDa6KcR3uvJ7eE6HOwNP2Irdw3O0 Yufz6MrRss2wKemBvaG/KWpPzJ7ZERjZP/ZVobeO/i9p1qwwH+JhAil4FQrHhntt OpouEZbE+q82pV0dzOhBHspEwvIdPstPe+513S5sKumcL1NIBi7e1NE8ENabAPpU tep9YubaLufdLi9ep813MnKKV1YpvP9bgl8oUwHP+XXc+WIayDr7wGFEpDGzxhCl 4uMRf6DoO6m5 =Kc4e -----END PGP SIGNATURE----- --=-ak+5xuqbdQ7xOTO4fu47--