public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl
@ 2017-05-20 13:02 Michał Górny
  2017-05-20 13:02 ` [gentoo-dev] [PATCH 2/2] distutils-r1.eclass: Remove QA-warning for DISTUTILS_NO_PARALLEL_BUILD Michał Górny
  2017-06-06  6:59 ` [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl Michał Górny
  0 siblings, 2 replies; 3+ messages in thread
From: Michał Górny @ 2017-05-20 13:02 UTC (permalink / raw)
  To: gentoo-dev; +Cc: python, Michał Górny

The function was (verbosely) deprecated in Dec 2014, and banned since
EAPI 6. It is no longer used by any ebuild in ::gentoo.
---
 eclass/python-r1.eclass | 35 -----------------------------------
 1 file changed, 35 deletions(-)

diff --git a/eclass/python-r1.eclass b/eclass/python-r1.eclass
index 809dc5f2b8e5..5eaa802e06b9 100644
--- a/eclass/python-r1.eclass
+++ b/eclass/python-r1.eclass
@@ -555,41 +555,6 @@ python_foreach_impl() {
 	multibuild_foreach_variant _python_multibuild_wrapper "${@}"
 }
 
-# @FUNCTION: python_parallel_foreach_impl
-# @USAGE: <command> [<args>...]
-# @DESCRIPTION:
-# Run the given command for each of the enabled Python implementations.
-# If additional parameters are passed, they will be passed through
-# to the command.
-#
-# The function will return 0 status if all invocations succeed.
-# Otherwise, the return code from first failing invocation will
-# be returned.
-#
-# For each command being run, EPYTHON, PYTHON and BUILD_DIR are set
-# locally, and the former two are exported to the command environment.
-#
-# This command used to be the parallel variant of python_foreach_impl.
-# However, the parallel run support has been removed to simplify
-# the eclasses and make them more predictable and therefore it is now
-# only a deprecated alias to python_foreach_impl.
-python_parallel_foreach_impl() {
-	debug-print-function ${FUNCNAME} "${@}"
-
-	[[ ${EAPI} == [45] ]] || die "${FUNCNAME} is banned in EAPI ${EAPI}"
-
-	if [[ ! ${_PYTHON_PARALLEL_WARNED} ]]; then
-		eqawarn "python_parallel_foreach_impl() is no longer meaningful. All runs"
-		eqawarn "are non-parallel now. Please replace the call with python_foreach_impl."
-
-		_PYTHON_PARALLEL_WARNED=1
-	fi
-
-	local MULTIBUILD_VARIANTS
-	_python_obtain_impls
-	multibuild_foreach_variant _python_multibuild_wrapper "${@}"
-}
-
 # @FUNCTION: python_setup
 # @USAGE: [<impl-pattern>...]
 # @DESCRIPTION:
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [gentoo-dev] [PATCH 2/2] distutils-r1.eclass: Remove QA-warning for DISTUTILS_NO_PARALLEL_BUILD
  2017-05-20 13:02 [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl Michał Górny
@ 2017-05-20 13:02 ` Michał Górny
  2017-06-06  6:59 ` [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl Michał Górny
  1 sibling, 0 replies; 3+ messages in thread
From: Michał Górny @ 2017-05-20 13:02 UTC (permalink / raw)
  To: gentoo-dev; +Cc: python, Michał Górny

The variable was deprecated and the warning put in place in Dec 2014. It
is no longer used in any ebuild in ::gentoo.
---
 eclass/distutils-r1.eclass | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index 6078fb6d52b7..e79f86bab12d 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -696,15 +696,6 @@ _distutils-r1_run_common_phase() {
 _distutils-r1_run_foreach_impl() {
 	debug-print-function ${FUNCNAME} "${@}"
 
-	if [[ ${DISTUTILS_NO_PARALLEL_BUILD} ]]; then
-		[[ ${EAPI} == [45] ]] || die "DISTUTILS_NO_PARALLEL_BUILD is banned in EAPI ${EAPI}"
-
-		eqawarn "DISTUTILS_NO_PARALLEL_BUILD is no longer meaningful. Now all builds"
-		eqawarn "are non-parallel. Please remove it from the ebuild."
-
-		unset DISTUTILS_NO_PARALLEL_BUILD # avoid repeated warnings
-	fi
-
 	# store for restoring after distutils-r1_run_phase.
 	local _DISTUTILS_INITIAL_CWD=${PWD}
 	set -- distutils-r1_run_phase "${@}"
-- 
2.13.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl
  2017-05-20 13:02 [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl Michał Górny
  2017-05-20 13:02 ` [gentoo-dev] [PATCH 2/2] distutils-r1.eclass: Remove QA-warning for DISTUTILS_NO_PARALLEL_BUILD Michał Górny
@ 2017-06-06  6:59 ` Michał Górny
  1 sibling, 0 replies; 3+ messages in thread
From: Michał Górny @ 2017-06-06  6:59 UTC (permalink / raw)
  To: gentoo-dev; +Cc: python

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

On sob, 2017-05-20 at 15:02 +0200, Michał Górny wrote:
> The function was (verbosely) deprecated in Dec 2014, and banned since
> EAPI 6. It is no longer used by any ebuild in ::gentoo.
> ---
>  eclass/python-r1.eclass | 35 -----------------------------------
>  1 file changed, 35 deletions(-)
> 

Merged both a while back.


-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 988 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-06  7:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-20 13:02 [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl Michał Górny
2017-05-20 13:02 ` [gentoo-dev] [PATCH 2/2] distutils-r1.eclass: Remove QA-warning for DISTUTILS_NO_PARALLEL_BUILD Michał Górny
2017-06-06  6:59 ` [gentoo-dev] [PATCH 1/2] python-r1.eclass: Remove deprecated python_parallel_foreach_impl Michał Górny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox