From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D15AA139694 for ; Wed, 10 May 2017 21:36:44 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A88B5E0CC7; Wed, 10 May 2017 21:36:34 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 58FA1E0C38 for ; Wed, 10 May 2017 21:36:34 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 6C4D733FE7D; Wed, 10 May 2017 21:36:31 +0000 (UTC) Message-ID: <1494452175.4139.1.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/3] python-utils-r1.eclass: Allow -2/-3 as impl-patterns for py2/py3 From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: python@gentoo.org Date: Wed, 10 May 2017 23:36:15 +0200 In-Reply-To: <20170510141506.2e40093b@patrickm> References: <20170510185333.6423-1-mgorny@gentoo.org> <20170510141506.2e40093b@patrickm> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-9Ojf2zqCfnDkmfi5M9G2" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 0fee2566-e3fb-4b01-b703-911a666a6c8d X-Archives-Hash: 845104f64edcaaaca086d43af2498476 --=-9Ojf2zqCfnDkmfi5M9G2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On =C5=9Bro, 2017-05-10 at 14:15 -0700, Patrick McLean wrote: > On Wed, 10 May 2017 20:53:31 +0200 > Micha=C5=82 G=C3=B3rny wrote: >=20 > > Allow two special values in the implementation patterns for > > _python_impl_matches(): -2 to indicate all Python 2-compatible > > implementations, and -3 to indicate all Python 3-compatible > > implementations. Both of those values are implemented using > > the python_is_python3 function. >=20 > Seems mostly reasonable, though the syntax is somewhat confusing at > first glance. There are many places where we use "-value" to negate, so > this looks like it means "not python 2" rather than "all python 2". > Perhaps something like '+2' would make it easier to read. Well, it was supposed to correspond to option parameters, so that it doesn't collide with regular template matching. But '+' works for me too, same as anything. Or '@2'. Or '${py2}' ;-P. >=20 > > This is mostly meant to make it easier and more fool-proof to write > > dependencies on backports to Python 2 which in most cases apply to > > PyPy2 as well. >=20 >=20 --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-9Ojf2zqCfnDkmfi5M9G2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAlkTh89fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI EQpGYRAAsGaCII5rYDoFPTOwZtPPW07TgC6/E74RccP5oK2RFxGXeJjMfWXIzInj ghKpp16+e8J4kfxySqrEYPqzFYfuQyHP3bnBf6kSJBaWA6k9eRzCZ7I0iUbrTDR3 CrAJahzhV/rSLnJm+JbiDpFKzrDbo0OZUCtvp7r8c3SPL7vAoz0yWHD2MqxkIWAd EGYskns8hU8RqkzDTKJGI6gBiNwVJuzo2SOjUlBXRHO4Ug54lgm2NvGPRlQC5Z67 AwtRMvR/Oq3laflOBeYIWSTYeTYQiSQFxyVLgIxLbVy28u5Kge5unkbQ5IKDOj1F e54GIqgZyIc5OQ7HPqlQEXCEgbXgZ5UoxlZQeE134lKy0EPJDm8yrlBWrFvX6IbO SAAM2p0mUMOyJOJDVQ9uu8ymebJGY5A14DX+YirgwqzC6cQybB5q0fc81Qn32/2o l1YSEpZHixfiVJjn7rXu7f3y772Qqt2LrSeS/HEjXn4j0adMte+BweR1WdX0oTg1 VEGVRo5xUMsxkr0dmw9BNWebxGOpHe1MtRP43YBl9puO/BFJpRDUCnubQjb3wNhS 6l/h2/bzdUNgS7tKZC535J/ktI3L0hdXugkdLM3pHp3uIzQA7AMPYtiqCUsNnQP+ OgnC+PLYCag+Odqk+dyROExJaWuYXbAVLF9eM0GaNpaXOIHuEJE= =T6xc -----END PGP SIGNATURE----- --=-9Ojf2zqCfnDkmfi5M9G2--