From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id F39E7139694 for ; Tue, 25 Apr 2017 18:45:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B4581E0D59; Tue, 25 Apr 2017 18:45:26 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 68E44E0D39 for ; Tue, 25 Apr 2017 18:45:26 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id E5822340AC7; Tue, 25 Apr 2017 18:45:24 +0000 (UTC) Message-ID: <1493145919.1582.1.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: make_desktop_entry, replace unnecessary extglob From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Tue, 25 Apr 2017 20:45:19 +0200 In-Reply-To: <20170414172542.11203-1-mgorny@gentoo.org> References: <20170414172542.11203-1-mgorny@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-vluK7YFvtSN0Q6uy7kNv" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 23ef5bd1-b356-4744-a855-38f83e7fac80 X-Archives-Hash: a0a180e14f560015ef85a8e21ad935d6 --=-vluK7YFvtSN0Q6uy7kNv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On pi=C4=85, 2017-04-14 at 19:25 +0200, Micha=C5=82 G=C3=B3rny wrote: > Replace the unnecessary use of extglob to strip file suffix > in make_desktop_entry with a plain ${x%.*}. This is pretty much > equivalent since match to one of the pre-defined suffixes is already > confirmed via the preceding conditional, and avoiding repeating > the suffix list twice makes the code simpler. > --- > eclass/eutils.eclass | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 Merged now. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-vluK7YFvtSN0Q6uy7kNv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAlj/mUBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI EQojsw/+IJmS5c01iFSmEfXnJT0Vf4Fy+Dge4ewY6mRZ+7NaMywhGrCexQpiKe6N 0+e2DR58e1enEp9XVb/n3ojPj5vCKIEctOBOURNb2nOrvzpq6mSit0hVUz6nnLeU kOM9HbjwOn+SmGWZxYDZY0tXX/GECu1V8AH2Rdi1yfM4Zvvwq0K8XkEKE7bEqZOF /BdwvU4abOgKA+Vlz1cvr+9twGIM6iSMLGrP1G/zRpXco7sutWhPf8S3wIhW+tSo jFOf8Js5c0G3tbbxRxFmyqQJRkbUD9ZEOO4Xcqc0E8ca4fJxi8/hal3Lp7Xn2Y4w M6XAuAkufAFPtDB6ARzAgGIaox7duitBKefbJR8TvSJu8xix+OIDpullOFxMhJv4 mpmsJiIkmDzwD3hI9IDWLEnrFcN+oL6Jr4sFI2wGVaAwIOnAGWFHY+NG/Pj3phjv 8lOK/po7dkX4uK5ygk/ztbIs1+KguyN37CsVtJ3UbHQXKJ7I7+W/wcQo5iePVZzd msVbIhb5zfmY35DrhbFNvGaQGr2s7H91np6BQyuJEBJ/7Ygv9CyzxcHkqvYp4ssi Obmk/t3LLEtmnAExV3pMDWGmWRYQML7K2+CtAcvfNajIYgWvp80XGhxryBTCm7EV uzETscDtJ4PcPT8utY3IktrWI9q8fe7dqpryYcgL9YUjEgzQJrU= =8IGe -----END PGP SIGNATURE----- --=-vluK7YFvtSN0Q6uy7kNv--