From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: make_desktop_entry, replace unnecessary extglob
Date: Tue, 25 Apr 2017 20:45:19 +0200 [thread overview]
Message-ID: <1493145919.1582.1.camel@gentoo.org> (raw)
In-Reply-To: <20170414172542.11203-1-mgorny@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
On pią, 2017-04-14 at 19:25 +0200, Michał Górny wrote:
> Replace the unnecessary use of extglob to strip file suffix
> in make_desktop_entry with a plain ${x%.*}. This is pretty much
> equivalent since match to one of the pre-defined suffixes is already
> confirmed via the preceding conditional, and avoiding repeating
> the suffix list twice makes the code simpler.
> ---
> eclass/eutils.eclass | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Merged now.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
prev parent reply other threads:[~2017-04-25 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 17:25 [gentoo-dev] [PATCH] eutils.eclass: make_desktop_entry, replace unnecessary extglob Michał Górny
2017-04-25 18:45 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493145919.1582.1.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox