Re: [gentoo-dev] [PATCH] gnome2-utils.eclass: gnome2_query_immodules*, use EROOT, #611030

[Gilles Dartiguelongue <eva@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Le samedi 22 avril 2017 à 23:03 +0200, Michał Górny a écrit :
> On sob, 2017-04-22 at 13:43 -0400, Mike Gilbert wrote:
> > 
> > On Sat, Apr 22, 2017 at 4:20 AM, Michał Górny <mgorny@gentoo.org>
> > wrote:
> > > 
> > > Respect EROOT when running gtk-query-immodules-* tools, alike
> > > other
> > > updaters in the eclass. This ensures that x11-libs/gtk+ installs
> > > correctly when installing to a ROOT.
> > 
> > I'm not an expert on this eclass, but it seems like this may be
> > intentional; calling compiled binaries from $ROOT will break for
> > cross-compiles.
> > 
> > Is there some package that installs ${CHOST}-gtk-query-immodules-
> > X.0
> > for ROOT == /? I don't have any such binary on my system.
> > 
> 
> I was thinking about this possibility too but it doesn't look like
> any
> of the remaining code was done like this, nor the GTK+ ebuild which
> calls this function. But I'll wait for the GNOME team to confirm what
> they want.
> 
Looking at the ebuilds, it looks like your patch is correct. I honestly
cannot remember why we used EPREFIX and not EROOT.

-- 
Gilles Dartiguelongue <eva@gentoo.org>

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 216 bytes --]