From: Mart Raudsepp <leio@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: gnome@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/7] gnome2-utils.eclass: Make gnome2_icon_cache_update update all themes
Date: Mon, 17 Apr 2017 16:32:04 +0300 [thread overview]
Message-ID: <1492435924.9279.1.camel@gentoo.org> (raw)
In-Reply-To: <1492429406.2270.0.camel@gentoo.org>
Ühel kenal päeval, E, 17.04.2017 kell 13:43, kirjutas Gilles
Dartiguelongue:
> Le lundi 17 avril 2017 à 13:07 +0200, Michał Górny a écrit :
> > Make the gnome2_icon_cache_update function update all icon themes
> > rather
> > than depending on gnome2_icon_savelist to select themes to update.
> > This
> > makes the function easier to use whenever the developer needs it
> > explicitly (i.e. knows that themes are installed), while the
> > overhead
> > of
> > regenerating multiple caches is neglible.
>
> Looks good.
I haven't looked at this yet, but it would be nice if a bunch of
gnome2.eclass and gnome2-utils.eclass would be pushed at once after
review for cache regeneration purposes. But of course not as important
as eutils was, but still hundreds - with gnome2-utils maybe a thousand.
Potential bugs that might end up needing an eclass change are at least
the following (might be more):
https://bugs.gentoo.org/615144
https://bugs.gentoo.org/613364
https://bugs.gentoo.org/show_bug.cgi?id=gnome2.eclass tracker
Mart
next prev parent reply other threads:[~2017-04-17 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 11:07 [gentoo-dev] [PATCH 1/7] gnome2-utils.eclass: Make gnome2_icon_cache_update update all themes Michał Górny
2017-04-17 11:07 ` [gentoo-dev] [PATCH 2/7] gnome2.eclass: Move GNOME2_ECLASS_ICONS conditional from gnome2-utils Michał Górny
2017-04-17 11:07 ` [gentoo-dev] [PATCH 3/7] kde4-base.eclass: " Michał Górny
2017-04-17 11:07 ` [gentoo-dev] [PATCH 4/7] kde5.eclass: " Michał Górny
2017-04-17 11:07 ` [gentoo-dev] [PATCH 5/7] xfconf.eclass: " Michał Górny
2017-04-17 11:07 ` [gentoo-dev] [PATCH 6/7] gnome2-utils.eclass: Remove GNOME2_ICONS conditional (moved to gnome2) Michał Górny
2017-04-17 11:07 ` [gentoo-dev] [PATCH 7/7] chromium.eclass: Remove no-longer necessary gnome2_icon_savelist call Michał Górny
2017-04-18 14:14 ` Mike Gilbert
2017-04-17 11:43 ` [gentoo-dev] [PATCH 1/7] gnome2-utils.eclass: Make gnome2_icon_cache_update update all themes Gilles Dartiguelongue
2017-04-17 13:32 ` Mart Raudsepp [this message]
2017-04-25 18:45 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492435924.9279.1.camel@gentoo.org \
--to=leio@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=gnome@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox