From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E1296139694 for ; Fri, 14 Apr 2017 16:32:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 404D3E0DCE; Fri, 14 Apr 2017 16:31:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EB713E0DC9 for ; Fri, 14 Apr 2017 16:31:25 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id CC58E341650; Fri, 14 Apr 2017 16:31:18 +0000 (UTC) Message-ID: <1492187475.14730.9.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] toolchain-glibc.eclass: Replace evar_* with local variables From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: base-system@gentoo.org Date: Fri, 14 Apr 2017 18:31:15 +0200 In-Reply-To: <20170324204446.23944-1-mgorny@gentoo.org> References: <20170324204446.23944-1-mgorny@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-ovprNN41IAvqZbt7bW+g" X-Mailer: Evolution 3.22.6 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 5758c972-1ea8-4899-b580-54bf4f95a93c X-Archives-Hash: 55220fa96dfc83d0d94fd4141fe3e8e2 --=-ovprNN41IAvqZbt7bW+g Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On pi=C4=85, 2017-03-24 at 21:44 +0100, Micha=C5=82 G=C3=B3rny wrote: > Use local variable to limit the scope of ABI variable override. This is > a builtin bash solution that is reliable and simple, unlike the complex > evar_* logic that unnecessarily pollutes global variables. > --- > eclass/toolchain-glibc.eclass | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/eclass/toolchain-glibc.eclass b/eclass/toolchain-glibc.eclas= s > index d410775759df..365198303e8f 100644 > --- a/eclass/toolchain-glibc.eclass > +++ b/eclass/toolchain-glibc.eclass > @@ -381,15 +381,13 @@ foreach_abi() { > else > abilist=3D${DEFAULT_ABI} > fi > - evar_push ABI > - export ABI > + local -x ABI > for ABI in ${abilist:-default} ; do > setup_env > einfo "Running $1 for ABI ${ABI}" > $1 > : $(( ret |=3D $? )) > done > - evar_pop > return ${ret} > } > =20 Merged. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-ovprNN41IAvqZbt7bW+g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAljw+VNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI EQqDjRAA4r0dhSysyek0QVnWL6pVv0jL06BL/ehzbWT13UE7wd27t0eVCGexrNcU NjPYbgcx6cWCHzq9c4L3qwc9zXmKDBcwQtQ4OOqS1TM2ndLluDOsaTtiffCb5xml BmHtIZdFx+Kh6BMc1N8oLuK7lE8VqmiMsLS22iVfuJ/2ULxZAAdkcFeENa6KpgDL kw3b7dCztt3eGjwL+90JbXhwUPqlL1hPMAbDZeIdrCcc2L9NPGBB8whNaqSSVUpf b2T152JuQlZuidnS1HoaZnVbbxkBU/lSbBLmiNzgL3wFY0B/XFcGmlzZ+QvhnugC 64YExDoftKcI4H1VHUXtdiTaBBCIeu8+CmFmL20aUAjZ0LxCXEg0UfhWIGkBElq1 A+6UDYABU4hcusetpqDWpdUn4X1qzHbeEG+7ocYlvkYI/DP8p1+Upqyfm8MOtYcC mDYCK2C5JSZoiWM6Zf74BHXhvSKtMqOiA24DUPkiTaUCkF4w17BJoz8zwX2Q3RId EIplL5Z7/+MyBCtoa5fMdoNunrySBk/AGHVAI2TFT1g+1tgf2EiMdQFzsxwkBkAx CtIqxUedU1h/kjQSKrNreLbQkdi+WwS/WMpuOS/AsvhkpnC315m+4YobGDuKD4Ht beQH4cpVAxWfM1ikmt0rQ3nwMOWYz0nZ3ChuUMJTRoUspxmsk98= =qhMc -----END PGP SIGNATURE----- --=-ovprNN41IAvqZbt7bW+g--