public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH dtd] glsa.dtd: Allow slot="" attribute for vulnerable&unaffected
Date: Wed, 12 Apr 2017 09:10:48 +0200	[thread overview]
Message-ID: <1491981048.1166.2.camel@gentoo.org> (raw)
In-Reply-To: <1491951460.14800.1.camel@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

On śro, 2017-04-12 at 01:57 +0300, Mart Raudsepp wrote:
> Ühel kenal päeval, T, 11.04.2017 kell 22:10, kirjutas Michał Górny:
> > ---
> >  glsa.dtd | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/glsa.dtd b/glsa.dtd
> > index 52be18e..22237b0 100644
> > --- a/glsa.dtd
> > +++ b/glsa.dtd
> > @@ -124,7 +124,8 @@
> >      Description:  Version of the vulnerable package. Can be a range
> > too
> 
> Maybe some slot attribute documentation could be added as well, similar
> to how the original patch attached to https://bugs.gentoo.org/106677
> did?

I'd rather not put more effort into the DTD than absolutely necessary.
I'm halfway porting it to XML Schema. Plus, a lot of the documentation
in the DTD is plain outdated. In fact, the patch in question has been
written against a different DTD file, more likely a better documented
version that was never committed.

>  Though not the "*" stuff, that feels wrong and should be just
> omitted attribute for that.

Not convinced about that. '*' is already used explicitly in arch='', so
I don't see a reason to not allow the same syntax here. This is also
what the Paludis implementation assumes, and it fits into slot operators
nicely.

Maybe I should just change the default from #IMPLIED to "*"? (i.e. make
omitted attribute equivalent to "*" DTD-wise)

-- 
Best regards,
Michał Górny

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

  reply	other threads:[~2017-04-12  7:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 20:10 [gentoo-dev] [PATCH dtd] glsa.dtd: Allow slot="" attribute for vulnerable&unaffected Michał Górny
2017-04-11 22:57 ` Mart Raudsepp
2017-04-12  7:10   ` Michał Górny [this message]
2017-04-12  7:28     ` Kristian Fiskerstrand
2017-04-13  5:39 ` [gentoo-dev] [PATCH v2] " Michał Górny
2017-04-17 15:37   ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491981048.1166.2.camel@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox