From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E3075139694 for ; Sun, 12 Mar 2017 12:20:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9946321C0DF; Sun, 12 Mar 2017 12:20:25 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 34B2F21C0C6 for ; Sun, 12 Mar 2017 12:20:25 +0000 (UTC) Received: from pomiot (d202-252.icpnet.pl [109.173.202.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 63DEA341421; Sun, 12 Mar 2017 12:20:23 +0000 (UTC) Message-ID: <1489321218.1067.10.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 2/3] eutils.eclass: prune_libtool_files, make .pc subst errors fatal From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Sun, 12 Mar 2017 13:20:18 +0100 In-Reply-To: <20170312123504.3842f572@gentoo.org> References: <20170312103943.23092-1-mgorny@gentoo.org> <20170312110009.3109-1-mgorny@gentoo.org> <20170312110009.3109-3-mgorny@gentoo.org> <20170312123504.3842f572@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RLS6iX6LhunCsP5fxui6" X-Mailer: Evolution 3.22.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 53fa8611-c5ab-46b7-9502-3221a338e2f5 X-Archives-Hash: f813002572051750294b0d8810778208 --=-RLS6iX6LhunCsP5fxui6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable W=C2=A0dniu 12.03.2017, nie o=C2=A0godzinie 12=E2=88=B635 +0100, u=C5=BCytk= ownik Alexis Ballier napisa=C5=82: > On Sun, 12 Mar 2017 12:00:08 +0100 > Micha=C5=82 G=C3=B3rny wrote: >=20 > > Make the substitution errors in prune_libtool_files logic fatal to > > avoid the dependency of eqawarn. They're extremely unlikely to happen > > anyway. --- > > eclass/eutils.eclass | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > >=20 > > diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass > > index ab226b236a37..cb472caee1d4 100644 > > --- a/eclass/eutils.eclass > > +++ b/eclass/eutils.eclass > > @@ -982,9 +982,10 @@ prune_libtool_files() { > > for arg in > > ${libs}; do if [[ ${arg} =3D=3D -l* ]]; then > > if > > [[ ${arg} =3D=3D '*$*' ]]; then > > - > > eqawarn "${FUNCNAME}: variable substitution likely failed in ${pc}" > > - > > eqawarn "(arg: ${arg})" > > - > > eqawarn "Most likely, you need to add virtual/pkgconfig to DEPEND." > > + > > eerror "${FUNCNAME}: variable substitution likely failed in ${pc}" > > + > > eerror "(arg: ${arg})" > > + > > eerror "Most likely, you need to add virtual/pkgconfig to DEPEND." > > + > > die "${FUNCNAME}: unsubstituted variable found in .pc" fi >=20 > If you go that way then it would be best if this function had a=20 > 'has "virtual/pkgconfig" ${DEPEND} || die ...' kind of logic You can't reliably query DEPEND in an ebuild. > the message is more intended towards package maintainer and i would > assume they have pkgconfig installed which means the failure will > be on user's throat ...in the extremely unlikely case of not having pkg-config installed. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-RLS6iX6LhunCsP5fxui6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEXr8g+Zb7PCLMb8pAur8dX/jIEQoFAljFPQNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDVF QkYyMEY5OTZGQjNDMjJDQzZGQ0E0MEJBQkYxRDVGRjhDODExMEEACgkQur8dX/jI EQoEfA/+JwJL+SX6p/dy9kFVd91T1IHtmdhSQDJ9MAaWoFY1kCqEXua6x4+jEXUY py4fpBEM37V2gZPI9EbslpbRh1FVlPQ+YEVUP9+JbTFdHZGWVTFQtbvkVs5KUKQU PN9fUtI452ak5Ki4NBeIvBXAOm+LuKzhfi3KeDF/J346FBOmcbU3UV10IH2SA8k0 y9wnABV7dz/He79BRCdpwe7alxRZKSfny8Mtmsmp/ARB7rHukgZRyo2BC2VVfRgm 9DAHJ9UIsUSZNwIqJoiwzkujg33DMPezo/9ILjNHooY4jhCDW7wEic8qTEfPWtOT Syip8lITVokxp3VKMS7CkERa5eEXDTpHAIw9h87EaXzh1G721g3iexaene82a4d2 Ndzb6LagKYFVoMQg4o+MnITD4o/K5Zquup5xz/nddhKIFAqwdOKF+WXg+WDeoY8O Wpnz2A0tj/VsPZB2fAb5wzAINBHsoZkDievDnYAkEp967++wyCspggFa7a/qwQ4q RquB0FPItRAb/mmSC4MDuX1NDAaF1g2Xmdx1OKvx0YFpdXhaS9K8X1kgAPRPkSDY wjchrr449PllnZ4uwclIz0IewajKC8cvBcC3OmGjwMA23tqFBqaf0/SHeb19E6mU PvYpvakTdwx17WjfN8vFC5qa0ls0lCVfcvcYGB+ikm/hekudBNc= =C5mN -----END PGP SIGNATURE----- --=-RLS6iX6LhunCsP5fxui6--