* [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror.
@ 2017-01-29 19:42 Matt Turner
2017-01-29 20:00 ` Sergei Trofimovich
2017-01-29 20:08 ` Matt Turner
0 siblings, 2 replies; 4+ messages in thread
From: Matt Turner @ 2017-01-29 19:42 UTC (permalink / raw
To: gentoo-dev; +Cc: x11, Matt Turner
Bug: https://bugs.gentoo.org/416069
---
eclass/xorg-2.eclass | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
index b7c7ba2..7d681f2 100644
--- a/eclass/xorg-2.eclass
+++ b/eclass/xorg-2.eclass
@@ -468,6 +468,11 @@ xorg-2_src_configure() {
local dep_track="--disable-dependency-tracking"
fi
+ # Check if package supports disabling of selective -Werror=...
+ if grep -q -s "disable-selective-werror" ${ECONF_SOURCE:-.}/configure; then
+ local dep_track="--disable-selective-werror"
+ fi
+
local myeconfargs=(
${dep_track}
${FONT_OPTIONS}
--
2.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror.
2017-01-29 19:42 [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror Matt Turner
@ 2017-01-29 20:00 ` Sergei Trofimovich
2017-01-29 20:07 ` Matt Turner
2017-01-29 20:08 ` Matt Turner
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2017-01-29 20:00 UTC (permalink / raw
To: Matt Turner; +Cc: gentoo-dev, x11
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On Sun, 29 Jan 2017 11:42:16 -0800
Matt Turner <mattst88@gentoo.org> wrote:
> Bug: https://bugs.gentoo.org/416069
> ---
> eclass/xorg-2.eclass | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
> index b7c7ba2..7d681f2 100644
> --- a/eclass/xorg-2.eclass
> +++ b/eclass/xorg-2.eclass
> @@ -468,6 +468,11 @@ xorg-2_src_configure() {
> local dep_track="--disable-dependency-tracking"
> fi
>
> + # Check if package supports disabling of selective -Werror=...
> + if grep -q -s "disable-selective-werror" ${ECONF_SOURCE:-.}/configure; then
> + local dep_track="--disable-selective-werror"
I guess you planned to use new local var name here (or '+='). Otherwise
code will drop --disable-dependency-tracking a few lines above.
> + fi
>
> local myeconfargs=(
> ${dep_track}
> ${FONT_OPTIONS}
--
Sergei
[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror.
2017-01-29 20:00 ` Sergei Trofimovich
@ 2017-01-29 20:07 ` Matt Turner
0 siblings, 0 replies; 4+ messages in thread
From: Matt Turner @ 2017-01-29 20:07 UTC (permalink / raw
To: Sergei Trofimovich; +Cc: gentoo development, x11
On Sun, Jan 29, 2017 at 12:00 PM, Sergei Trofimovich <slyfox@gentoo.org> wrote:
> On Sun, 29 Jan 2017 11:42:16 -0800
> Matt Turner <mattst88@gentoo.org> wrote:
>
>> Bug: https://bugs.gentoo.org/416069
>> ---
>> eclass/xorg-2.eclass | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
>> index b7c7ba2..7d681f2 100644
>> --- a/eclass/xorg-2.eclass
>> +++ b/eclass/xorg-2.eclass
>> @@ -468,6 +468,11 @@ xorg-2_src_configure() {
>> local dep_track="--disable-dependency-tracking"
>> fi
>>
>> + # Check if package supports disabling of selective -Werror=...
>> + if grep -q -s "disable-selective-werror" ${ECONF_SOURCE:-.}/configure; then
>> + local dep_track="--disable-selective-werror"
>
> I guess you planned to use new local var name here (or '+='). Otherwise
> code will drop --disable-dependency-tracking a few lines above.
Derp. Thanks for noticing.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror.
2017-01-29 19:42 [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror Matt Turner
2017-01-29 20:00 ` Sergei Trofimovich
@ 2017-01-29 20:08 ` Matt Turner
1 sibling, 0 replies; 4+ messages in thread
From: Matt Turner @ 2017-01-29 20:08 UTC (permalink / raw
To: gentoo-dev; +Cc: x11, Matt Turner
Bug: https://bugs.gentoo.org/416069
---
eclass/xorg-2.eclass | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
index b7c7ba2..fabad09 100644
--- a/eclass/xorg-2.eclass
+++ b/eclass/xorg-2.eclass
@@ -468,8 +468,14 @@ xorg-2_src_configure() {
local dep_track="--disable-dependency-tracking"
fi
+ # Check if package supports disabling of selective -Werror=...
+ if grep -q -s "disable-selective-werror" ${ECONF_SOURCE:-.}/configure; then
+ local selective_werror="--disable-selective-werror"
+ fi
+
local myeconfargs=(
${dep_track}
+ ${selective_werror}
${FONT_OPTIONS}
"${xorgconfadd[@]}"
)
--
2.7.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-29 20:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-29 19:42 [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror Matt Turner
2017-01-29 20:00 ` Sergei Trofimovich
2017-01-29 20:07 ` Matt Turner
2017-01-29 20:08 ` Matt Turner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox