From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E270758973 for ; Wed, 20 Jan 2016 10:50:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DA1F921C1A5; Wed, 20 Jan 2016 10:45:40 +0000 (UTC) Received: from mail.astralcloak.net (astralcloak.net [66.246.75.167]) by pigeon.gentoo.org (Postfix) with ESMTP id 0B3B021C19C for ; Wed, 20 Jan 2016 10:45:40 +0000 (UTC) Received: from mail.astralcloak.net (mail.astralcloak.net [127.0.0.1]) by mail.astralcloak.net (Postfix) with ESMTPSA id 42AC45E From: Michael Palimaka To: gentoo-dev@lists.gentoo.org Cc: Michael Palimaka Subject: [gentoo-dev] [PATCH 10/15] cmake-utils.eclass: ban non-array usage of mycmakeargs in EAPI 6 and later Date: Wed, 20 Jan 2016 21:43:08 +1100 Message-Id: <1453286593-26823-11-git-send-email-kensington@gentoo.org> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1453286593-26823-1-git-send-email-kensington@gentoo.org> References: <1453286593-26823-1-git-send-email-kensington@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Archives-Salt: d7b204d2-4066-4bcc-bd20-2bbd3834333a X-Archives-Hash: 2eb854865e28e09c445c253e858f80d9 --- eclass/cmake-utils.eclass | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass index 22c8718..e6d77ef 100644 --- a/eclass/cmake-utils.eclass +++ b/eclass/cmake-utils.eclass @@ -583,7 +583,11 @@ enable_cmake-utils_src_configure() { local mycmakeargstype=$(declare -p mycmakeargs 2>&-) if [[ "${mycmakeargstype}" != "declare -a mycmakeargs="* ]]; then if [[ -n "${mycmakeargstype}" ]] ; then - eqawarn "Declaring mycmakeargs as a variable is deprecated. Please use an array instead." + if has "${EAPI:-0}" 2 3 4 5 ; then + eqawarn "Declaring mycmakeargs as a variable is deprecated. Please use an array instead." + else + die "Declaring mycmakeargs as a variable is banned in EAPI=${EAPI}. Please use an array instead." + fi fi local mycmakeargs_local=(${mycmakeargs}) else -- 2.4.10