From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 3FC471384B4 for ; Fri, 1 Jan 2016 16:50:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C1D2D21C111; Fri, 1 Jan 2016 16:41:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 37BD821C101 for ; Fri, 1 Jan 2016 16:41:58 +0000 (UTC) Received: from localhost.localdomain (d202-251.icpnet.pl [109.173.202.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id E2630340A4A; Fri, 1 Jan 2016 16:41:51 +0000 (UTC) From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Subject: [gentoo-dev] [PATCH 12/15] scons-utils.eclass: _scons_clean_makeopts, stop exporting cache vars Date: Fri, 1 Jan 2016 17:41:18 +0100 Message-Id: <1451666481-22145-13-git-send-email-mgorny@gentoo.org> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1451666481-22145-1-git-send-email-mgorny@gentoo.org> References: <1451666481-22145-1-git-send-email-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Archives-Salt: aa3fb14a-368e-4e32-9326-8501aa638403 X-Archives-Hash: 4e2b894068a9e0d0467fadec5cd00967 Cache vars need only to be global to be preserved across calls. Exporting them is undesired. --- eclass/scons-utils.eclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eclass/scons-utils.eclass b/eclass/scons-utils.eclass index 4da2c4a..82e45e3 100644 --- a/eclass/scons-utils.eclass +++ b/eclass/scons-utils.eclass @@ -177,7 +177,7 @@ _scons_clean_makeopts() { debug-print "Cache hit: [${SCONSOPTS}]" return fi - export _SCONS_CACHE_MAKEOPTS=${*} + _SCONS_CACHE_MAKEOPTS=${*} while [[ ${#} -gt 0 ]]; do case ${1} in @@ -236,7 +236,7 @@ _scons_clean_makeopts() { done set -- ${new_makeopts} - export _SCONS_CACHE_SCONSOPTS=${*} + _SCONS_CACHE_SCONSOPTS=${*} debug-print "New SCONSOPTS: [${*}]" SCONSOPTS=${*} } -- 2.6.4