From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 233981381F3 for ; Thu, 2 May 2013 15:35:14 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F24F0E0B09; Thu, 2 May 2013 15:35:09 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0350BE0B06 for ; Thu, 2 May 2013 15:35:08 +0000 (UTC) Received: from [192.168.1.204] (unknown [87.217.142.0]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pacho) by smtp.gentoo.org (Postfix) with ESMTPSA id 9583C33BE50 for ; Thu, 2 May 2013 15:35:07 +0000 (UTC) Message-ID: <1367508903.21951.18.camel@localhost> Subject: Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games From: Pacho Ramos To: gentoo-dev@lists.gentoo.org Date: Thu, 02 May 2013 17:35:03 +0200 In-Reply-To: <51828365.2050806@gentoo.org> References: <1367491272.21951.8.camel@localhost> <51825D64.2010905@gentoo.org> <1367502051.21951.12.camel@localhost> <5182701C.8040209@gentoo.org> <1367507567.21951.16.camel@localhost> <51828365.2050806@gentoo.org> Content-Type: multipart/mixed; boundary="=-MwXiGSXX8Rb6gvaOukEJ" X-Mailer: Evolution 3.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: 95de6c1a-1ce4-42a9-968b-830c9bb25d53 X-Archives-Hash: 519f8241be69939ecd3240748ce22fe7 --=-MwXiGSXX8Rb6gvaOukEJ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit El jue, 02-05-2013 a las 17:16 +0200, hasufell escribió: > On 05/02/2013 05:12 PM, Pacho Ramos wrote: > > El jue, 02-05-2013 a las 15:54 +0200, hasufell escribió: > >> On 05/02/2013 03:40 PM, Pacho Ramos wrote: > >>> El jue, 02-05-2013 a las 14:34 +0200, hasufell escribió: > >>>> On 05/02/2013 12:41 PM, Pacho Ramos wrote: > >>>>> gnome-games was splitted in separate packages per game and, then, we > >>>>> need an eclass to also set proper settings inherited from gnome2 and > >>>>> games eclasses. This should also solve: > >>>>> https://bugs.gentoo.org/show_bug.cgi?id=432848 > >>>>> > >>>>> eclass and ebuild (games-puzzle/five-or-more) to try attached > >>>>> > >>>> > >>>> This does not honour GAMES_DATADIR afais. > >>> > >>> They cannot honor it since installing all stuff under /usr/share/games > >>> will lead to them even failing to start (I tried it before). > >>> > >> > >> Why? > >> > >> It's a common problem that people hardcode data dir destination in their > >> source files, assuming that people only want to install into /usr/share. > >> That is simply a bug and needs to be fixed in the package (it also means > >> it will probably fail for /usr/local and many other usecases, so this is > >> not even a gentoo specific bug). > >> > >> You cannot fix that on eclass level and it is not a reason to drop > >> supporting GAMES_DATADIR variable. That is inconsistent and does not > >> make sense. You would even get mixed permissions unless you fix that up too. > >> > > > > I don't understand why games team makes all this prefix work, isn't > > changing permissions of installed files enough? > > > > I doubt if upstream will be ok with installing > > schemas/translations/gtk-doc stuff under this prefix :/ > > > > schemas/translations/gtk-doc don't need to be installed under that > prefix. Sometimes you have to seperate install locations, otherwise you > would end up getting pixmaps in /usr/share/games/pixmaps and such. > > That sometimes needs some micro-management. Datafiles should _always_ > have a seperate switch to choose the destination. This is another attempt, some pending problems are: - localedir is wrongly chosen - it installs /var stuff under /var/games/games instead of /var/games :S --=-MwXiGSXX8Rb6gvaOukEJ Content-Disposition: attachment; filename="gnome-games.eclass" Content-Type: text/plain; name="gnome-games.eclass"; charset="UTF-8" Content-Transfer-Encoding: 7bit # Copyright 1999-2013 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: /var/cvsroot/gentoo-x86/eclass/python-single-r1.eclass,v 1.16 2013/04/07 17:02:52 mgorny Exp $ # @ECLASS: gnome-games # @MAINTAINER: # Gnome team # @AUTHOR: # Author: Pacho Ramos # @BLURB: An eclass to build gnome-games. # @DESCRIPTION: # An eclass to build gnome-games using proper phases from gnome2 and # games eclasses. case "${EAPI:-0}" in 0|1) die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}" ;; 2|3|4|5) ;; *) die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}" ;; esac inherit games gnome2 EXPORT_FUNCTIONS pkg_setup src_prepare src_configure src_compile src_install pkg_preinst pkg_postinst pkg_postrm if [[ ! ${_GNOME_GAMES} ]]; then RDEPEND="!gnome-extra/gnome-games" # @FUNCTION: gnome-games_pkg_setup # @DESCRIPTION: # Set proper phase defaults gnome-games_pkg_setup() { debug-print-function ${FUNCNAME} "${@}" games_pkg_setup } # @FUNCTION: gnome-games_src_prepare # @DESCRIPTION: # Set proper phase defaults gnome-games_src_prepare() { debug-print-function ${FUNCNAME} "${@}" gnome2_src_prepare } # @FUNCTION: gnome-games_src_configure # @DESCRIPTION: # Set proper phase defaults, relying on gnome2_src_configure # and passing extra arguments from egamesconf (games.eclass) gnome-games_src_configure() { debug-print-function ${FUNCNAME} "${@}" gnome2_src_configure \ --bindir="${GAMES_BINDIR}" \ --libdir="$(games_get_libdir)" \ --sysconfdir="${GAMES_SYSCONFDIR}" \ --localstatedir="${GAMES_STATEDIR}" \ --prefix="${GAMES_PREFIX}" \ --localedir=/usr/share/locale \ "$@" # GAMES_DATADIR causes games to fail to run due schemas and other # files getting installed in unexpected places # --datadir="${GAMES_DATADIR}" # # We need to not set GAMES_PREFIX to get translations working # --localedir="${EPREFIX}"/usr/share/locale is not enough # --prefix="${GAMES_PREFIX}" -> setting bindir instead } # @FUNCTION: gnome-games_src_compile # @DESCRIPTION: # Set proper phase defaults gnome-games_src_compile() { debug-print-function ${FUNCNAME} "${@}" gnome2_src_compile } # @FUNCTION: gnome-games_src_install # @DESCRIPTION: # Set proper phase defaults gnome-games_src_install() { debug-print-function ${FUNCNAME} "${@}" gnome2_src_install prepgamesdirs } # @FUNCTION: gnome-games_pkg_preinst # @DESCRIPTION: # Set proper phase defaults gnome-games_pkg_preinst() { debug-print-function ${FUNCNAME} "${@}" gnome2_pkg_preinst games_pkg_preinst } # @FUNCTION: gnome-games_pkg_preinst # @DESCRIPTION: # Set proper phase defaults gnome-games_pkg_postinst() { debug-print-function ${FUNCNAME} "${@}" gnome2_pkg_postinst games_pkg_postinst } # @FUNCTION: gnome-games_pkg_postrm # @DESCRIPTION: # Set proper phase defaults gnome-games_pkg_postrm() { debug-print-function ${FUNCNAME} "${@}" gnome2_pkg_postrm } _GNOME_GAMES=1 fi --=-MwXiGSXX8Rb6gvaOukEJ--