From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8074E1381F3 for ; Thu, 2 May 2013 15:12:56 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 04413E0B1D; Thu, 2 May 2013 15:12:53 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 298B9E0B03 for ; Thu, 2 May 2013 15:12:52 +0000 (UTC) Received: from [192.168.1.204] (185.147.16.95.dynamic.jazztel.es [95.16.147.185]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pacho) by smtp.gentoo.org (Postfix) with ESMTPSA id 84EE233DFCA; Thu, 2 May 2013 15:12:50 +0000 (UTC) Message-ID: <1367507567.21951.16.camel@localhost> Subject: Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games From: Pacho Ramos To: gentoo-dev@lists.gentoo.org Cc: gnome@gentoo.org Date: Thu, 02 May 2013 17:12:47 +0200 In-Reply-To: <5182701C.8040209@gentoo.org> References: <1367491272.21951.8.camel@localhost> <51825D64.2010905@gentoo.org> <1367502051.21951.12.camel@localhost> <5182701C.8040209@gentoo.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: c70faf1b-c1e2-4c3c-90e9-0614d8ff19b7 X-Archives-Hash: f299e1185037ce26ec994b18280d6b5c El jue, 02-05-2013 a las 15:54 +0200, hasufell escribió: > On 05/02/2013 03:40 PM, Pacho Ramos wrote: > > El jue, 02-05-2013 a las 14:34 +0200, hasufell escribió: > >> On 05/02/2013 12:41 PM, Pacho Ramos wrote: > >>> gnome-games was splitted in separate packages per game and, then, we > >>> need an eclass to also set proper settings inherited from gnome2 and > >>> games eclasses. This should also solve: > >>> https://bugs.gentoo.org/show_bug.cgi?id=432848 > >>> > >>> eclass and ebuild (games-puzzle/five-or-more) to try attached > >>> > >> > >> This does not honour GAMES_DATADIR afais. > > > > They cannot honor it since installing all stuff under /usr/share/games > > will lead to them even failing to start (I tried it before). > > > > Why? > > It's a common problem that people hardcode data dir destination in their > source files, assuming that people only want to install into /usr/share. > That is simply a bug and needs to be fixed in the package (it also means > it will probably fail for /usr/local and many other usecases, so this is > not even a gentoo specific bug). > > You cannot fix that on eclass level and it is not a reason to drop > supporting GAMES_DATADIR variable. That is inconsistent and does not > make sense. You would even get mixed permissions unless you fix that up too. > I don't understand why games team makes all this prefix work, isn't changing permissions of installed files enough? I doubt if upstream will be ok with installing schemas/translations/gtk-doc stuff under this prefix :/ > >> > >> "prepgamesdirs" is missing completely too. > >> > >> So those games will not be compliant with the games.eclass standard. > >> > > > > In games.eclass I see you have prepgamesdirs but don't call it on any > > exported phase from games.eclass :-/, how are other games calling it? > > > > > > You call it explicitly. > In src_install, no?