public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Pacho Ramos <pacho@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: gnome@gentoo.org
Subject: Re: [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games
Date: Thu, 02 May 2013 17:12:47 +0200	[thread overview]
Message-ID: <1367507567.21951.16.camel@localhost> (raw)
In-Reply-To: <5182701C.8040209@gentoo.org>

El jue, 02-05-2013 a las 15:54 +0200, hasufell escribió:
> On 05/02/2013 03:40 PM, Pacho Ramos wrote:
> > El jue, 02-05-2013 a las 14:34 +0200, hasufell escribió:
> >> On 05/02/2013 12:41 PM, Pacho Ramos wrote:
> >>> gnome-games was splitted in separate packages per game and, then, we
> >>> need an eclass to also set proper settings inherited from gnome2 and
> >>> games eclasses. This should also solve:
> >>> https://bugs.gentoo.org/show_bug.cgi?id=432848
> >>>
> >>> eclass and ebuild (games-puzzle/five-or-more) to try attached
> >>>
> >>
> >> This does not honour GAMES_DATADIR afais.
> > 
> > They cannot honor it since installing all stuff under /usr/share/games
> > will lead to them even failing to start (I tried it before).
> > 
> 
> Why?
> 
> It's a common problem that people hardcode data dir destination in their
> source files, assuming that people only want to install into /usr/share.
> That is simply a bug and needs to be fixed in the package (it also means
> it will probably fail for /usr/local and many other usecases, so this is
> not even a gentoo specific bug).
> 
> You cannot fix that on eclass level and it is not a reason to drop
> supporting GAMES_DATADIR variable. That is inconsistent and does not
> make sense. You would even get mixed permissions unless you fix that up too.
> 

I don't understand why games team makes all this prefix work, isn't
changing permissions of installed files enough?

I doubt if upstream will be ok with installing
schemas/translations/gtk-doc stuff under this prefix :/

> >>
> >> "prepgamesdirs" is missing completely too.
> >>
> >> So those games will not be compliant with the games.eclass standard.
> >>
> > 
> > In games.eclass I see you have prepgamesdirs but don't call it on any
> > exported phase from games.eclass :-/, how are other games calling it?
> > 
> > 
> 
> You call it explicitly.
> 

In src_install, no?



  reply	other threads:[~2013-05-02 15:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 10:41 [gentoo-dev] gnome-games.eclass: Eclass for installing all gnome-games Pacho Ramos
2013-05-02 12:34 ` hasufell
2013-05-02 13:40   ` Pacho Ramos
2013-05-02 13:54     ` hasufell
2013-05-02 15:12       ` Pacho Ramos [this message]
2013-05-02 15:16         ` hasufell
2013-05-02 15:35           ` Pacho Ramos
2013-06-27 20:25             ` Pacho Ramos
2013-06-27 20:38               ` hasufell
2013-06-27 20:43                 ` Pacho Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367507567.21951.16.camel@localhost \
    --to=pacho@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=gnome@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox