From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C9F461381F3 for ; Sat, 6 Apr 2013 18:35:59 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BF6DAE07D7; Sat, 6 Apr 2013 18:35:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D3C27E07CA for ; Sat, 6 Apr 2013 18:35:50 +0000 (UTC) Received: from [192.168.1.43] (pool-71-246-221-8.washdc.fios.verizon.net [71.246.221.8]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: tetromino) by smtp.gentoo.org (Postfix) with ESMTPSA id 760EE33DC01 for ; Sat, 6 Apr 2013 18:35:49 +0000 (UTC) Message-ID: <1365273347.9078.9.camel@rook> Subject: Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean From: Alexandre Rostovtsev To: gentoo-dev@lists.gentoo.org Date: Sat, 06 Apr 2013 14:35:47 -0400 In-Reply-To: <20130406200843.6831c4fe@pomiocik.lan> References: <20130406200843.6831c4fe@pomiocik.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: adb52f43-8572-41a2-a793-3f90e08368f7 X-Archives-Hash: a54ee271bd629e0a1f322d5d40383047 On Sat, 2013-04-06 at 20:08 +0200, Michał Górny wrote: > 2. Patches have to apply to the top directory of the source tree with > 'patch -p1'. If patches are applied to sub-directories, necessary '-p' > argument shall be passed to 'epatch' explicitly. Developers are > encouraged to create patches which are compatible with 'git am'. Please don't make -p1 into a hard requirement :/ There are upstreams who have different directory layouts in their scm tree and in their source tarballs. If I clone an upstream git repository to obtain a patch or to write a new patch that I will submit upstream, I want to be able to apply that patch in an ebuild without having to manually sed it to change the -p level. Specific examples of this among packages that I maintain: app-cdr/cdemu, app-cdr/cdemu-daemon, sys-fs/vhba. These all use the same git tree, and source tarballs for individual packages are created from different subdirectories of that git tree.