From: Alexandre Rostovtsev <tetromino@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean
Date: Sat, 06 Apr 2013 14:35:47 -0400 [thread overview]
Message-ID: <1365273347.9078.9.camel@rook> (raw)
In-Reply-To: <20130406200843.6831c4fe@pomiocik.lan>
On Sat, 2013-04-06 at 20:08 +0200, Michał Górny wrote:
> 2. Patches have to apply to the top directory of the source tree with
> 'patch -p1'. If patches are applied to sub-directories, necessary '-p'
> argument shall be passed to 'epatch' explicitly. Developers are
> encouraged to create patches which are compatible with 'git am'.
Please don't make -p1 into a hard requirement :/
There are upstreams who have different directory layouts in their scm
tree and in their source tarballs. If I clone an upstream git repository
to obtain a patch or to write a new patch that I will submit upstream, I
want to be able to apply that patch in an ebuild without having to
manually sed it to change the -p level.
Specific examples of this among packages that I maintain: app-cdr/cdemu,
app-cdr/cdemu-daemon, sys-fs/vhba. These all use the same git tree, and
source tarballs for individual packages are created from different
subdirectories of that git tree.
next prev parent reply other threads:[~2013-04-06 18:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 18:08 [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean Michał Górny
2013-04-06 18:20 ` Tony "Chainsaw" Vroon
2013-04-06 18:22 ` Markos Chandras
2013-04-07 13:43 ` [gentoo-dev] " Michael Palimaka
2013-04-06 18:35 ` Alexandre Rostovtsev [this message]
2013-04-06 18:59 ` [gentoo-dev] " Michael Mol
2013-04-06 18:59 ` Michał Górny
2013-04-06 19:02 ` "Paweł Hajdan, Jr."
2013-04-06 19:27 ` Alex Xu
2013-04-06 19:41 ` Michał Górny
2013-04-06 20:00 ` "Paweł Hajdan, Jr."
2013-04-06 21:41 ` Michał Górny
2013-04-09 19:31 ` Donnie Berkholz
2013-04-06 20:32 ` [gentoo-dev] " Paul Arthur
2013-04-06 21:01 ` [gentoo-dev] " Robin H. Johnson
2013-04-07 14:36 ` [gentoo-dev] " Michael Palimaka
2013-04-07 19:22 ` Robin H. Johnson
2013-04-07 6:53 ` [gentoo-dev] " Kacper Kowalik
2013-04-07 14:30 ` [gentoo-dev] " Michael Palimaka
2013-04-12 13:51 ` Steven J. Long
2013-04-30 4:44 ` Ryan Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365273347.9078.9.camel@rook \
--to=tetromino@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox