From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 468AA138010 for ; Wed, 27 Mar 2013 12:39:30 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 38631E09AD; Wed, 27 Mar 2013 12:39:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4EC87E09A9 for ; Wed, 27 Mar 2013 12:39:25 +0000 (UTC) Received: from [217.70.181.52] (gilles.gandi.net [217.70.181.52]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eva) by smtp.gentoo.org (Postfix) with ESMTPSA id 05D2333DBB4 for ; Wed, 27 Mar 2013 12:39:23 +0000 (UTC) Message-ID: <1364387960.24497.6.camel@gilles.gandi.net> Subject: Re: [gentoo-dev] Proposed update to pax-utils.eclass From: Gilles Dartiguelongue To: gentoo-dev@lists.gentoo.org Date: Wed, 27 Mar 2013 13:39:20 +0100 In-Reply-To: <514F9840.7030204@gentoo.org> References: <5145B4B9.3070104@gentoo.org> <514F9840.7030204@gentoo.org> Organization: Gentoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.3 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Archives-Salt: f52d5ce1-882e-4cd6-9f8d-f8e6d75b3b91 X-Archives-Hash: 21ace2de5e46fc1984909b49cab6a072 Le dimanche 24 mars 2013 à 20:20 -0400, Anthony G. Basile a écrit : > Last call, does anyone have a problem with me updating the > pax-utils.eclass? See Ref [3] above for the code. I'll wait a couple > more days and then do it. looks like last conditional branch for XT marking in pax-mark function is not using the proper variables (pt_* instead ot xt_*). The PAX_MARKINGS variable is not documented with eclass documentation markup, it should at least get an "@INTERNAL" if this is not supposed to be modified by eclass users. _pax_list_files can receive documentation this way as well. You should probably try to avoid mixing [[ ]] and [ ] in the eclass. [ ] seems to be less used here so just have everything [[ ]] and drop the useless quoting that came with [ ]. The rest looks fine. -- Gilles Dartiguelongue Gentoo