From: Steev Klimaszewski <steev@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: ryao@gentoo.org
Subject: Re: [gentoo-dev] [RFC] patch linux-mod.eclass to add support for module signing
Date: Wed, 06 Mar 2013 13:32:40 -0600 [thread overview]
Message-ID: <1362598360.502.1.camel@oswin.hackershack.net> (raw)
In-Reply-To: <CA+ZvHYHJEa+9BXkFd6hjMQNyptC1PD+Qxx8ue4CCtLD6DH-xBw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
-----Original Message-----
From: Carlos Silva <r3pek@r3pek.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] [RFC] patch linux-mod.eclass to add support for
module signing
Date: Wed, 6 Mar 2013 18:25:38 -0100
@@ -663,7 +696,7 @@
# This looks messy, but it is needed to handle multiple variables
# being passed in the BUILD_* stuff where the variables also have
- # spaces that must be preserved. If don't do this, then the stuff
+ # spaces that must be preserved. If dont do this, then the stuff
# inside the variables gets used as targets for Make, which then
# fails.
eval "emake HOSTCC=\"$(tc-getBUILD_CC)\" \
^^ Why did you remove the ' in don't ? Seems like it was an mistake?
The rest looks fine to me, maybe Ryao can chime in, I know he was
interested in module signing.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2013-03-06 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 19:25 [gentoo-dev] [RFC] patch linux-mod.eclass to add support for module signing Carlos Silva
2013-03-06 19:32 ` Steev Klimaszewski [this message]
2013-03-06 19:54 ` Carlos Silva
2013-03-06 21:39 ` Peter Stuge
2013-03-06 22:07 ` Carlos Silva
2013-03-06 22:14 ` Peter Stuge
2013-03-06 22:19 ` Carlos Silva
2013-03-08 17:44 ` [gentoo-dev] " Steven J. Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362598360.502.1.camel@oswin.hackershack.net \
--to=steev@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ryao@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox