From: Pacho Ramos <pacho@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] readme.gentoo.eclass: Add a readme.gentoo_force_print_elog function to force elog printing
Date: Thu, 24 Jan 2013 22:39:01 +0100 [thread overview]
Message-ID: <1359063541.2927.6.camel@belkin4> (raw)
In-Reply-To: <3677854.t0mX8Gnp0i@arcarius>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
El jue, 24-01-2013 a las 21:42 +0100, Tomáš Chvátal escribió:
> Dne Čt 24. ledna 2013 21:33:45, Pacho Ramos napsal(a):
> > El mar, 22-01-2013 a las 19:42 +0100, Tomáš Chvátal escribió:
> > > Dne Út 22. ledna 2013 19:37:12, Pacho Ramos napsal(a):
> > > > I agree, thanks for pointing it. Just attached patch should handle it.
> > >
> > > Still not nice enough for me :D
> > >
> > > Use the ECLASS_VARIABLE to describe it @DEFAULT_UNSET is what you seek,
> > > see
> > > git-2.eclass.
> > >
> > > Tom
> >
> > What about this one?
>
> - if ! [[ "${REPLACING_VERSIONS}" ]] || [[ "${FORCE_PRINT_ELOG}" ]]; then
> + if ! [[ -n "${REPLACING_VERSIONS}" || -n "${FORCE_PRINT_ELOG}" ]]; then
>
> But thats just cosmetic
>
> Tom
Done, and committed
+ 24 Jan 2013; Pacho Ramos <pacho@gentoo.org> readme.gentoo.eclass:
+ Include FORCE_PRINT_ELOG variable to for printing of messages when
desired.
+ Thanks to Tomáš Chvátal for his suggestions.
+
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-01-24 21:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 21:08 [gentoo-dev] readme.gentoo.eclass: Add a readme.gentoo_force_print_elog function to force elog printing Pacho Ramos
2013-01-22 7:16 ` Tomáš Chvátal
2013-01-22 8:07 ` Pacho Ramos
2013-01-22 9:33 ` Tomáš Chvátal
2013-01-22 18:37 ` Pacho Ramos
2013-01-22 18:42 ` Tomáš Chvátal
2013-01-24 20:33 ` Pacho Ramos
2013-01-24 20:42 ` Tomáš Chvátal
2013-01-24 21:39 ` Pacho Ramos [this message]
2013-02-01 14:32 ` Fabio Erculiani
2013-02-01 14:34 ` Fabio Erculiani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359063541.2927.6.camel@belkin4 \
--to=pacho@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox