From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id E06E71385FF for ; Tue, 22 Jan 2013 18:37:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2714621C076; Tue, 22 Jan 2013 18:37:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 027A221C002 for ; Tue, 22 Jan 2013 18:37:16 +0000 (UTC) Received: from [192.168.1.33] (210.Red-2-137-15.dynamicIP.rima-tde.net [2.137.15.210]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pacho) by smtp.gentoo.org (Postfix) with ESMTPSA id 8852333DAC8 for ; Tue, 22 Jan 2013 18:37:15 +0000 (UTC) Subject: Re: [gentoo-dev] readme.gentoo.eclass: Add a readme.gentoo_force_print_elog function to force elog printing From: Pacho Ramos To: gentoo-dev@lists.gentoo.org In-Reply-To: References: <1358802503.2064.49.camel@belkin4> <1358842021.2064.55.camel@belkin4> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-OBgIIVheLcQzWO9bes2Q" Date: Tue, 22 Jan 2013 19:37:12 +0100 Message-ID: <1358879832.2064.63.camel@belkin4> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 X-Archives-Salt: 2aed5733-d589-4ed5-8989-49df712321b7 X-Archives-Hash: d82c5dbaee6a1cf4ecceab18b7d3d014 --=-OBgIIVheLcQzWO9bes2Q Content-Type: multipart/mixed; boundary="=-wadnQ4esoNBI8uLqPTCI" --=-wadnQ4esoNBI8uLqPTCI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El mar, 22-01-2013 a las 10:33 +0100, Tom=C3=A1=C5=A1 Chv=C3=A1tal escribi= =C3=B3: > 2013/1/22 Pacho Ramos : > > El mar, 22-01-2013 a las 08:16 +0100, Tom=C3=A1=C5=A1 Chv=C3=A1tal escr= ibi=C3=B3: > >> Would'nt be better to just set some variable in the ebuild, rather > >> than call function that touches empty file? > >> > >> Tom > >> > >> > > > > I think it can be done in either way... but I don't see the advantage o= f > > any over the other :/ >=20 > Just few I can think of right now: >=20 > You can set the variable in the ebuilds global scope somewhere on top eas= ily. > You can actually do more magic later based on what content user puts > to the variable if we want to (all msgs, important ones only, ...) > You actually allow user to enforce this behaviour in make conf for all > packages if he desires to do so. >=20 > Also I never seen this being handled by touching files in any other eclas= ses :-) >=20 > Tom >=20 >=20 I agree, thanks for pointing it. Just attached patch should handle it. --=-wadnQ4esoNBI8uLqPTCI Content-Disposition: attachment; filename="1.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="1.patch"; charset="UTF-8" LS0tIHJlYWRtZS5nZW50b28uZWNsYXNzCTIwMTMtMDEtMjAgMTI6NDI6MzAuMDAwMDAwMDAwICsw MTAwDQorKysgL3Vzci9wb3J0YWdlL2VjbGFzcy9yZWFkbWUuZ2VudG9vLmVjbGFzcwkyMDEzLTAx LTIyIDE5OjM2OjEyLjAwMDAwMDAwMCArMDEwMA0KQEAgLTY4LDEzICs2OCwyMCBAQA0KIA0KICMg QEZVTkNUSU9OOiByZWFkbWUuZ2VudG9vX3ByaW50X2Vsb2cNCiAjIEBERVNDUklQVElPTjoNCi0j IFByaW50IGVsb2cgbWVzc2FnZXMgd2l0aCAiJHtUfSIvUkVBRE1FLmdlbnRvbyBjb250ZW50cy4N CisjIFByaW50IGVsb2cgbWVzc2FnZXMgd2l0aCAiJHtUfSIvUkVBRE1FLmdlbnRvbyBjb250ZW50 cy4gVGhleSB3aWxsIGJlDQorIyBzaG93biBvbmx5IHdoZW4gcGFja2FnZSBpcyBpbnN0YWxsZWQg YXQgZmlyc3QgdGltZS4NCiAjIFVzdWFsbHkgY2FsbGVkIGF0IHBrZ19wb3N0aW5zdCBwaGFzZS4N CisjDQorIyBJZiB5b3Ugd2FudCB0byBzaG93IHRoZW0gYWx3YXlzLCBwbGVhc2Ugc2V0IEZPUkNF X1BSSU5UX0VMT0cgdG8gYSBub24gZW1wdHkNCisjIHZhbHVlIGluIHlvdXIgZWJ1aWxkIGJlZm9y ZSB0aGlzIGZ1bmN0aW9uIGlzIGNhbGxlZC4NCisjIFRoaXMgY2FuIGJlIHVzZWZ1bCB3aGVuLCBm b3IgZXhhbXBsZSwgRE9DX0NPTlRFTlRTIGlzIG1vZGlmaWVkLCB0aGVuLCB5b3UgY2FuDQorIyBy ZWx5IG9uIHNwZWNpZmljIFJFUExBQ0lOR19WRVJTSU9OUyBoYW5kbGluZyBpbiB5b3VyIGVidWls ZCB0byBwcmludCBtZXNzYWdlcw0KKyMgd2hlbiBwZW9wbGUgdXBkYXRlIGZyb20gdmVyc2lvbnMg c3RpbGwgcHJvdmlkaW5nIG9sZCBtZXNzYWdlLg0KIHJlYWRtZS5nZW50b29fcHJpbnRfZWxvZygp IHsNCiAJZGVidWctcHJpbnQtZnVuY3Rpb24gJHtGVU5DTkFNRX0gIiR7QH0iDQogDQogCWlmIFtb IC1mICIke1R9Ii9SRUFETUUuZ2VudG9vIF1dOyB0aGVuDQotCQlpZiAhIFtbICIke1JFUExBQ0lO R19WRVJTSU9OU30iIF1dOyB0aGVuDQorCQlpZiAhIFtbICIke1JFUExBQ0lOR19WRVJTSU9OU30i IF1dIHx8IFtbICIke0ZPUkNFX1BSSU5UX0VMT0d9IiBdXTsgdGhlbg0KIAkJCWVzaG9wdHNfcHVz aA0KIAkJCXNldCAtZg0KIAkJCWNhdCAiJHtUfSIvUkVBRE1FLmdlbnRvbyB8IHdoaWxlIHJlYWQg LXIgRUxJTkU7IGRvIGVsb2cgIiR7RUxJTkV9IjsgZG9uZQ0K --=-wadnQ4esoNBI8uLqPTCI-- --=-OBgIIVheLcQzWO9bes2Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEABECAAYFAlD+3FgACgkQCaWpQKGI+9Q1DgCfaUAm0qUA6/slPrV7jUgl9Rlb 6egAnRZKHyGtnVEfnDHtD8FBxPRRbJLa =+odr -----END PGP SIGNATURE----- --=-OBgIIVheLcQzWO9bes2Q--