From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 17AE21381F3 for ; Sun, 18 Nov 2012 23:01:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 39F0121C124; Sun, 18 Nov 2012 23:01:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3490A21C123 for ; Sun, 18 Nov 2012 23:00:53 +0000 (UTC) Received: from [192.168.0.53] (nsg93-9-78-225-4-220.fbx.proxad.net [78.225.4.220]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eva) by smtp.gentoo.org (Postfix) with ESMTPSA id 24558335E30 for ; Sun, 18 Nov 2012 23:00:50 +0000 (UTC) Message-ID: <1353279584.23950.17.camel@kanae> Subject: Re: [gentoo-dev] Re: gstreamer eclass review From: Gilles Dartiguelongue To: gentoo-dev@lists.gentoo.org Date: Sun, 18 Nov 2012 23:59:44 +0100 In-Reply-To: References: <1353265590.23950.13.camel@kanae> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-KK7bKha1nzsq3iPtffKZ" X-Mailer: Evolution 3.6.1 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 X-Archives-Salt: d09f24b7-7131-45ca-8ab6-e4a3e228007b X-Archives-Hash: 2a3b9b37a04c283df5506755801011ff --=-KK7bKha1nzsq3iPtffKZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le dimanche 18 novembre 2012 =C3=A0 20:45 +0000, Duncan a =C3=A9crit : > Gilles Dartiguelongue posted on Sun, 18 Nov 2012 20:06:30 +0100 as > excerpted: >=20 [...] > But as I said up top, that's (mostly, the pattern matching vs string > matching will occasionally bite if you're not on the lookout for it) > trivial style stuff. You may well prefer the way it is now. But in that > case, why the counter-example, omitting if/then? (You may of course > fairly point out that consistency is a trivial style thing too. =3D:^) I admittedly didn't really look for consistency in these details. I picked stuff from the 4 eclasses and merged them in one, having the gnome2 eclasses open for reference which might explain some inconsistencies in style. Anyway if you read all that up and only mailed about this, I guess you found no problem with the rest, right ? --=20 Gilles Dartiguelongue Gentoo --=-KK7bKha1nzsq3iPtffKZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEABEKAAYFAlCpaGAACgkQ1fmVwcYIWAbKngCfeu/iBb5JObzToDygPviO5/af eLQAn3U9g/9fOJ+O1KsE3+Lb28+qFWin =TquN -----END PGP SIGNATURE----- --=-KK7bKha1nzsq3iPtffKZ--