From: Gilles Dartiguelongue <eva@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: gstreamer eclass review
Date: Sun, 18 Nov 2012 23:59:44 +0100 [thread overview]
Message-ID: <1353279584.23950.17.camel@kanae> (raw)
In-Reply-To: <pan.2012.11.18.20.45.31@cox.net>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
Le dimanche 18 novembre 2012 à 20:45 +0000, Duncan a écrit :
> Gilles Dartiguelongue posted on Sun, 18 Nov 2012 20:06:30 +0100 as
> excerpted:
>
[...]
> But as I said up top, that's (mostly, the pattern matching vs string
> matching will occasionally bite if you're not on the lookout for it)
> trivial style stuff. You may well prefer the way it is now. But in that
> case, why the counter-example, omitting if/then? (You may of course
> fairly point out that consistency is a trivial style thing too. =:^)
I admittedly didn't really look for consistency in these details. I
picked stuff from the 4 eclasses and merged them in one, having the
gnome2 eclasses open for reference which might explain some
inconsistencies in style.
Anyway if you read all that up and only mailed about this, I guess you
found no problem with the rest, right ?
--
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-11-18 23:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 19:06 [gentoo-dev] gstreamer eclass review Gilles Dartiguelongue
2012-11-18 20:45 ` [gentoo-dev] " Duncan
2012-11-18 22:59 ` Gilles Dartiguelongue [this message]
2012-11-19 4:23 ` Duncan
2012-11-18 23:13 ` Alec Warner
2012-11-21 15:27 ` [gentoo-dev] " Tomáš Chvátal
2012-11-21 20:54 ` Gilles Dartiguelongue
2012-12-06 4:01 ` Maxim Kammerer
2012-12-06 8:40 ` Gilles Dartiguelongue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353279584.23950.17.camel@kanae \
--to=eva@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox