From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-54192-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id 4E246138010
	for <garchives@archives.gentoo.org>; Mon, 27 Aug 2012 04:47:03 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id A64D9E04EB;
	Mon, 27 Aug 2012 04:46:42 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id A649DE04AB
	for <gentoo-dev@lists.gentoo.org>; Mon, 27 Aug 2012 04:45:48 +0000 (UTC)
Received: from [192.168.1.43] (unknown [96.231.195.182])
	(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: tetromino)
	by smtp.gentoo.org (Postfix) with ESMTPSA id AC86D33D709
	for <gentoo-dev@lists.gentoo.org>; Mon, 27 Aug 2012 04:45:47 +0000 (UTC)
Message-ID: <1346042745.9829.112.camel@rook>
Subject: Re: [gentoo-dev] [RFC] new vala.eclass
From: Alexandre Rostovtsev <tetromino@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Date: Mon, 27 Aug 2012 00:45:45 -0400
In-Reply-To: <20120826224553.700b29ca@gentoo.org>
References: <1345910966.9829.9.camel@rook> <1345928676.9829.13.camel@rook>
	 <20537.18304.877062.568911@a1i15.kph.uni-mainz.de>
	 <1345964385.9829.80.camel@rook> <503AA725.8020306@gentoo.org>
	 <1346024612.9829.87.camel@rook> <20120826224553.700b29ca@gentoo.org>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.4.4 
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 7c393811-52a5-4dad-8f0a-51ea9b6a085d
X-Archives-Hash: d27336327510f4bfa39d6ab01f990ca2

On Sun, 2012-08-26 at 22:45 -0400, Alexis Ballier wrote:
> On Sun, 26 Aug 2012 19:43:32 -0400
> Alexandre Rostovtsev <tetromino@gentoo.org> wrote:
> > The variables that vala_pkg_setup sets are needed only at build time.
> 
> so it should be vala_src_prepare / unpack instead ?
> definitely not anything pkg_* imho

IMHO src_prepare or src_unpack would be misleading because the function
does not modify the package's source and has nothing to do with
unpacking. It's not an unusual idiom to set various environment
variables in pkg_setup even if those variables are relevant only at
build time; gnome-extra/zeitgeist and xfce4-vala/xfce4-vala are typical
examples that already export VALAC in their pkg_setup().